Test how to do blocking hand-off between TBB and module thread

[Dr15Jones]

PR description:

• Introduces a module and test to experiment with a module specific thread accessing Framework infrastructure (e.g. RandomNumber service, MessageLogger, etc).
• Created an abstract interface for the MessageLogger service which allows manual configuration of context

PR validation:

All framework tests plus the newly added test pass.

resolves cms-sw/framework-team#167

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34084/23246

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Integration
FWCore/MessageLogger
FWCore/MessageService

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-286116/15883/summary.html
COMMIT: 291ce4e
CMSSW: CMSSW_12_0_X_2021-06-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34084/15883/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• [ALCA] Apply code-checks/format with misc-definitions-in-headers #34032 @smuzaffar: [ALCA] Apply code-checks/format with misc-definitions-in-headers
• [L1] Apply code-checks/format with misc-definitions-in-headers #34048 @smuzaffar: [L1] Apply code-checks/format with misc-definitions-in-headers
• [GENERATORS] Apply code-checks/format with misc-definitions-in-headers #34043 @smuzaffar: [GENERATORS] Apply code-checks/format with misc-definitions-in-headers

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-286116/15883/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-286116/15883/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/MuonFSRProducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/MuonMCClassifier.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/TriggerMatcherToHLTDebug.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/TriggerObjectFilterByCollection.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/TriggerMatcherToHLTDebug.cc:57:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/poison/FWCore/MessageService/interface/MessageLogger.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/src/MuonAnalysis/MuonAssociators/plugins/TriggerMatcherToHLTDebug.cc:57:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-06-10-1100/poison/FWCore/MessageService/interface/MessageLogger.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.


Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34084/23292

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

Pull request #34084 was updated. @smuzaffar, @Dr15Jones, @makortel, @Martin-Grunewald, @rekovic, @fwyzard, @santocch, @cecilecaillol can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-286116/15920/summary.html
COMMIT: 54aa65d
CMSSW: CMSSW_12_0_X_2021-06-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34084/15920/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862485
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[fwyzard]

+hlt

[cecilecaillol]

+l1

[Dr15Jones]

@cms-sw/analysis-l2 @cms-sw/core-l2 ping

[makortel]

+1

[qliphy]

+1

[qliphy]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.