Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSC/DT rechits to AOD[backport] #34066

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Add CSC/DT rechits to AOD[backport] #34066

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e462180
Add CSC/DT rechits to AOD
Jun 9, 2021
7632eaf
update output for bparking era only
Jun 9, 2021
490faa3
update bparking
Jun 9, 2021
571953e
fix syntax
Jun 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion RecoLocalMuon/Configuration/python/RecoLocalMuon_EventContent_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
)
# AOD content
RecoLocalMuonAOD = cms.PSet(
outputCommands = cms.untracked.vstring(
outputCommands = cms.untracked.vstring(
'keep *_dt4DSegments_*_*',
'keep *_dt4DCosmicSegments_*_*',
'keep *_cscSegments_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, both DT segments and CSC segments are already available in AOD.
It would be nice to see some slides/material showing that segments do not work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 For the record, we checked in simulation that rechits provides much better signal-background discrimination. A more detailed discussion is also documented in the AN of EXO-20-015, section 4.1

image

Expand All @@ -35,7 +35,9 @@ def _updateOutput( era, outputPSets, commands):
from Configuration.Eras.Modifier_run2_GEM_2017_cff import run2_GEM_2017
from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM
from Configuration.Eras.Modifier_phase2_muon_cff import phase2_muon
from Configuration.Eras.Modifier_bParking_cff import bParking
_outputs = [RecoLocalMuonFEVT, RecoLocalMuonRECO, RecoLocalMuonAOD]
_updateOutput(bParking, RecoLocalMuonAOD, ['keep *_dt1DRecHits_*_*', 'keep *_csc2DRecHits_*_*'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_updateOutput(bParking, RecoLocalMuonAOD, ['keep *_dt1DRecHits_*_*', 'keep *_csc2DRecHits_*_*'])
_updateOutput(bParking, [RecoLocalMuonAOD], ['keep *_dt1DRecHits_*_*', 'keep *_csc2DRecHits_*_*'])

I guess this is going to fix the crashes.
Please double-check in a local test (parsing a config is enough)

_updateOutput( run2_GEM_2017, _outputs, ['keep *_gemRecHits_*_*', 'keep *_gemSegments_*_*'] )
_updateOutput( run3_GEM, _outputs, ['keep *_gemRecHits_*_*', 'keep *_gemSegments_*_*'] )
_updateOutput(phase2_muon, _outputs, ['keep *_me0RecHits_*_*', 'keep *_me0Segments_*_*'])