LowPtElectrons: NanoAOD integration (forward port) #34005

bainbrid · 2021-06-07T22:19:32Z

PR description:

This PR adds some minor fixes to the python config that steers the addition of low-pT electrons to the NanoAOD content, done in #33817.

The same minor fixes are already included in the back port PR #33992 to 10_6_X.

This PR ensures consistency between 10_6_X and master.

The changes are as follows:

the LeptonUpdater module was mistakenly removed from PhysicsTools/NanoAOD/python/lowPtElectrons_cff.py in an earlier simplification to LowPtElectrons: NanoAOD integration #33817; here it is added back with the param computeMiniIso=True, required to correctly compute the variables miniPFRelIso_chg and miniPFRelIso_all.
the low-pT nano DQM plots have been updated: miniPFRelIso_chg and miniPFRelIso_all have a minor axis range tweak; ip3d and sip3d have been removed as they are not computed.

PR validation:

Local tests with wfs 1325.81, 136.8523, and 136.88811.

if this PR is a backport please specify the original PR and why you need to backport that PR:

These changes are already included in the back port PR #33992 to 10_6_X.

… DQM: fix miniPFRelIso_chg/all, remove s/ip3d histos

bainbrid · 2021-06-07T22:19:39Z

@mariadalfonso @gouskos @crovelli @cavalari @jainshilpi @lfinco

cmsbuild · 2021-06-07T22:25:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34005/23127

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Add Muon L1 to prefire weight producer #33758

cmsbuild · 2021-06-07T22:26:11Z

A new Pull Request was created by @bainbrid for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

gouskos · 2021-06-07T22:28:32Z

please test

cmsbuild · 2021-06-08T02:12:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39b0b1/15738/summary.html
COMMIT: 5ff103d
CMSSW: CMSSW_12_0_X_2021-06-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34005/15738/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648335
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2648306
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.255 KiB( 36 files compared)
DQMHistoSizes: changed ( 1325.81 ): -0.759 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 136.8523 ): -0.500 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: found differences in 7 / 36 workflows

mariadalfonso · 2021-06-08T07:34:56Z

This PR fix the empty variables as reported in
#33817 (comment)

The miniPFRelIso_chg and all are now filled

mariadalfonso · 2021-06-08T07:42:06Z

The DQM plots are now saved for all possible nanos, altought empty for when the lowPtElectron doesn't run.
in principle can be customized in PhysicsTools/NanoAOD/python/nanoDQM_cff.py
with the same set of modifiers used in
https://github.com/cms-sw/cmssw/pull/33817/files#diff-31eff23ea52a2b619e0192f0f8d2e89b7e1740522a692066a66284fc43d547f5R195-R203

mariadalfonso · 2021-06-08T07:42:52Z

urgent

(mark what is needed for the nanov9)

mariadalfonso · 2021-06-08T08:16:34Z

PhysicsTools/NanoAOD/python/lowPtElectrons_cff.py

                               doc="mini PF relative isolation, charged component"),
-        miniPFRelIso_all = Var("userFloat('miniIsoAll')/pt",float,


Are these relative isolation or not ?
In this last PR the division for the pt is removed

Yes, they are rel. iso. even if the name suggests not. So the /pt is no longer needed. This is now done here.

mariadalfonso · 2021-06-08T08:20:14Z

one more things we can do for master is to clean these warnings
https://github.com/cms-sw/cmssw/pull/33817/files#r645094126

bainbrid · 2021-06-08T08:34:45Z

one more things we can do for master is to clean these warnings
https://github.com/cms-sw/cmssw/pull/33817/files#r645094126

I should fix this in this PR?

mariadalfonso · 2021-06-08T08:35:12Z

one more things we can do for master is to clean these warnings
https://github.com/cms-sw/cmssw/pull/33817/files#r645094126

I should fix this in this PR?

yes, fine for me

bainbrid · 2021-06-08T08:41:39Z

one more things we can do for master is to clean these warnings
https://github.com/cms-sw/cmssw/pull/33817/files#r645094126

I should fix this in this PR?

yes, fine for me

after discussing privately, we've agreed to factorise this non-essential fix into a separate PR.

And keep this PR is nano-specific.

mariadalfonso · 2021-06-08T15:45:35Z

The DQM plots are now saved for all possible nanos, altought empty for when the lowPtElectron doesn't run.
in principle can be customized in PhysicsTools/NanoAOD/python/nanoDQM_cff.py
with the same set of modifiers used in
https://github.com/cms-sw/cmssw/pull/33817/files#diff-31eff23ea52a2b619e0192f0f8d2e89b7e1740522a692066a66284fc43d547f5R195-R203

we agreed to defer this update to another PR in master

mariadalfonso · 2021-06-08T15:46:53Z

+xpog

this PR fix two variables spotted to be broken
the feature is already in 10_6 for nanov9

cmsbuild · 2021-06-08T15:47:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-08T16:03:19Z

+1

add LeptonUpdater, computeMiniIso=True; isoForLowPtEle.relative=True;…

5ff103d

… DQM: fix miniPFRelIso_chg/all, remove s/ip3d histos

cmsbuild added this to the CMSSW_12_0_X milestone Jun 7, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Jun 7, 2021

bainbrid mentioned this pull request Jun 7, 2021

LowPtElectrons: NanoAOD integration (back port of #33817) #33992

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 7, 2021

cmsbuild added tests-started and removed tests-pending labels Jun 7, 2021

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2021

mariadalfonso mentioned this pull request Jun 8, 2021

features for V9 nanoAOD cms-nanoAOD/cmssw#555

Closed

55 tasks

cmsbuild added the urgent label Jun 8, 2021

mariadalfonso reviewed Jun 8, 2021

View reviewed changes

cmsbuild mentioned this pull request Jun 8, 2021

Add Muon L1 to prefire weight producer #33758

Merged

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jun 8, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 8, 2021

cmsbuild merged commit a6b8acc into cms-sw:master Jun 8, 2021

cmsbuild mentioned this pull request Jun 9, 2021

[DQM] Apply code-checks/format with misc-definitions-in-headers #34039

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LowPtElectrons: NanoAOD integration (forward port) #34005

LowPtElectrons: NanoAOD integration (forward port) #34005

bainbrid commented Jun 7, 2021

bainbrid commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

gouskos commented Jun 7, 2021

cmsbuild commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso Jun 8, 2021

bainbrid Jun 8, 2021

mariadalfonso commented Jun 8, 2021

bainbrid commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

bainbrid commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 8, 2021

		doc="mini PF relative isolation, charged component"),
		miniPFRelIso_all = Var("userFloat('miniIsoAll')/pt",float,

LowPtElectrons: NanoAOD integration (forward port) #34005

LowPtElectrons: NanoAOD integration (forward port) #34005

Conversation

bainbrid commented Jun 7, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

bainbrid commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

cmsbuild commented Jun 7, 2021

gouskos commented Jun 7, 2021

cmsbuild commented Jun 8, 2021

Comparison Summary

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso Jun 8, 2021

Choose a reason for hiding this comment

bainbrid Jun 8, 2021

Choose a reason for hiding this comment

mariadalfonso commented Jun 8, 2021

bainbrid commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

bainbrid commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

mariadalfonso commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 8, 2021