Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement persistence for ProcessBlock products #33969

Merged
merged 26 commits into from
Jul 18, 2021
Merged
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b0972e1
Implement persistence for ProcessBlock products
wddgit Sep 15, 2020
4469486
Minor style improvements, PR comments
wddgit Jun 16, 2021
baad1a6
Remove unnecessary duplicate functions
wddgit Jun 17, 2021
6708351
Move virtual function to source file
wddgit Jun 17, 2021
8cb78de
Replace for loop which std::find_if
wddgit Jun 17, 2021
f59a113
Replace non-const accessors
wddgit Jun 17, 2021
44b5107
Make interface more flexible
wddgit Jun 17, 2021
3625c41
Remove unnecessary line
wddgit Jun 17, 2021
e2b4a3a
Rename function to moveProcessBlockCacheFiller
wddgit Jun 18, 2021
2202de0
Use implicit conversion, more readable
wddgit Jun 18, 2021
e92d6af
Make constructor explicit
wddgit Jun 18, 2021
a494229
code format
wddgit Jun 24, 2021
f61791a
Use set functions instead of non-const accessor
wddgit Jun 24, 2021
a06c464
Make functions private and test module a friend
wddgit Jun 24, 2021
05e0ce1
Change override to final
wddgit Jun 24, 2021
bac65d1
Use pass by value instead of &&
wddgit Jun 24, 2021
ce8b3a5
Test new set function
wddgit Jun 25, 2021
390d967
Use ranged-for loops
wddgit Jun 25, 2021
02dbc67
Don't use moved object after move
wddgit Jun 25, 2021
ec4699b
expectedByRun make first element run 1, use at
wddgit Jun 28, 2021
d08a916
Remove CMS_THREAD_SAFE from atomic variables
wddgit Jun 28, 2021
22a00ef
Use catch2 STATIC_REQUIRE instead of REQUIRE
wddgit Jun 28, 2021
258dbf2
Use constexpr variable instead of hard coding
wddgit Jun 30, 2021
d12a76b
Fix failure return value in unit test
wddgit Jun 30, 2021
bf90eae
Initialize treePointers_ using the enums
wddgit Jul 7, 2021
6ecbb27
Improvements to ProcessBlock test script/BuildFile
wddgit Jul 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make constructor explicit
  • Loading branch information
wddgit committed Jul 9, 2021
commit e92d6af641d093134416f13fd9e2fb8c0d814338
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ namespace edm {
// This constructor exists for ROOT I/O
StoredProcessBlockHelper();

StoredProcessBlockHelper(std::vector<std::string> const& processesWithProcessBlockProducts);
explicit StoredProcessBlockHelper(std::vector<std::string> const& processesWithProcessBlockProducts);

std::vector<std::string> const& processesWithProcessBlockProducts() const {
return processesWithProcessBlockProducts_;