[Backport] Adding offlineVerticesWithBS to miniAOD to 10_6_X

[AdrianoDee]

PR description:

This is a backport of #33778. The same results apply.

PR validation:

All tests run. Given no bParking wf is included (AFAIK) in the recommended test, the 1304.181has been tested (successfully). See results here.

[cmsbuild]

A new Pull Request was created by @AdrianoDee for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9620f2/15486/summary.html
COMMIT: e95b74d
CMSSW: CMSSW_10_6_X_2021-05-31-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33922/15486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215543
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215207
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[perrotta]

A few observations:

• The new collection is added to miniAOD in case of bParking OR if run2_miniAOD_devel: bParking production in 10_6 has not yet been done AFAIK, therefore, this shouldn't actually add anything to current productions in 10_6
• In any case, this PR only eventually adds new products, and it doesn't touch any existing one
• HI related modifications are not backported: aren't they needed in 10_6 HI miniAOD? I don't think any miniAOD HI production is foreseen with 10_6, but @mandrenguyen could you please confirm?
• @AdrianoDee I cannot check the output of your test: could you please confirm that you verified that the expected extra output was present there?

[AdrianoDee]

• @AdrianoDee I cannot check the output of your test: could you please confirm that you verified that the expected extra output was present there?

I've checked it locally with the 1304.181 and the new collection is in the miniAOD output. Worth to run a test with this workflow added as extra?

[perrotta]

• @AdrianoDee I cannot check the output of your test: could you please confirm that you verified that the expected extra output was present there?

I've checked it locally with the 1304.181 and the new collection is in the miniAOD output. Worth to run a test with this workflow added as extra?

Do you mean, running with this PR instead of your local setup? Yes, please do so: it should be fast, anyhow

[AdrianoDee]

I meant running cmsbuild tests with the extra workflow. Anyway: I'm testing the wf with the PR merged on a clean 10_6_X IB, let's see the outcome.

[AdrianoDee]

Checked, everything was smooth and the collection was there (just for your information step4.root in here).

[mandrenguyen]

@perrotta That's correct, there is no HI miniAOD production intended for 10_6. I don't know whether any future PbPb re-miniAOD will happen in 12_X_Y or in 11_2_X, as the previous one. In the latter case, I guess one should consider backporting to 11_2.

[perrotta]

+1

• offlineVerticesWithBS added to miniAOD only if bParking OR run2_miniAOD_devel: no changes to the usual workflow outputs in other cases
• Differently from the master version of this PR, the same additions do not apply for HI miniAOD: this is correct, because no re-miniAOD is foreseen for HI with 10_6: if needed, backport in the relevant release for a possible future HI re-miniAOD will have to be prepared
• Otherwise, the backport is identical to the original PR in master
• Jenkins tests pass and show no differences, coherently to what above

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@perrotta That's correct, there is no HI miniAOD production intended for 10_6. I don't know whether any future PbPb re-miniAOD will happen in 12_X_Y or in 11_2_X, as the previous one. In the latter case, I guess one should consider backporting to 11_2.

Thank you @mandrenguyen : I expect that HI will take care of organizing the possible backport in the relevant release, only if and when needed

[qliphy]

+1

[AdrianoDee]

Thanks!