Fix import in Phase1L1TJetSumsProducer_cfi for python 3 #33822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33822/22823
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: L1Trigger/L1CaloTrigger @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters
|
|
@cmsbuild, please test |
|
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestDQMOfflineConfiguration50 had ERRORS ---> test TestDQMOfflineConfiguration0 had ERRORS ---> test TestDQMOfflineConfiguration100 had ERRORS ---> test TestDQMOfflineConfiguration200 had ERRORS and more ... RelValsExpand to see more relval errors ...AddOn TestsExpand to see more addon errors ...
|
|
@cmsbuild, please test |
|
Ok, the latest PY3 IB is already too old. |
|
-1 Failed Tests: UnitTests RelVals AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestDQMOfflineConfiguration0 had ERRORS ---> test TestDQMOfflineConfiguration50 had ERRORS ---> test TestDQMOfflineConfiguration100 had ERRORS ---> test TestDQMOfflineConfiguration200 had ERRORS and more ... RelValsExpand to see more relval errors ...AddOn TestsExpand to see more addon errors ...
|
|
test parameters |
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals RelVals-INPUT AddOn The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelValsExpand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn TestsExpand to see more addon errors ...
|
|
@cmsbuild, please test |
|
test parameters:
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c770c/15292/summary.html Comparison SummarySummary:
|
|
+Upgrade Same fix as #33747 to make python 2 and 3 compatible. |
|
+1 |
|
+l1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This should fix the failures seen in CMSSW_12_0_PY3_X_2021-05-23-2300
PR validation:
None