Phase-2 Inner Tracker: combined backport of 33495 and 33508 #33792

mmusich · 2021-05-20T07:41:44Z

PR description:

This is a combined backport of the commit of PRs #33495 and #33508.
The changes propose here are needed to fix some minor issues with the determination of the template CPE reconstruction in the case of the Pixel 3D sensors for the Phase-2 inner tracker.
More discussion is available at: #33495 (comment).
Commit 2044fd5 removes the changes that break the current online menus in 11.3.X (introduced after #33792 (comment)).
A backport has become necessary in order to allow the production of a small set of samples for detailed POG-level checks on different phase-2 Inner Tracker sensor choices to be handled in CMSSW_11_3_X.

PR validation:

Tested and validated privately in the master branch. It compiles in the 11.3.X branch. The branch has also been tested successfully with addOnTests.py.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of the commits of PRs #33495 and #33508.

@cms-sw/upgrade-l2 @emiglior FYI.

cmsbuild · 2021-05-20T07:42:04Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_3_X.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation
HLTrigger/Configuration
RecoLocalTracker/SiPixelRecHits

@perrotta, @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @fwyzard, @kpedro88, @Martin-Grunewald, @srimanob, @tlampen, @slava77, @jpata, @cmsbuild, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @gpetruc, @OzAmram, @tocheng, @ferencek, @mtosi, @mmusich, @dkotlins, @threus, @fabiocos, @slomeo, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-05-20T07:47:50Z

@cmsbuild, please test

Martin-Grunewald · 2021-05-20T08:38:24Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

@@ -129,11 +129,26 @@ def customiseFor2018Input(process):

    return process

+def customiseFor33495(process):


Should be customiseFor33792.

However, could this customisation and changes in this file just be removed, and the parameters in question be labelled "obsolete" in fillDescriptions of the plugins, such that configs containing them would still work?
Reason is that online does not use this customisation, and we also do not want to break old 11_3 menus.

@Martin-Grunewald, commit 2044fd5 addresses your comment and incidentally remove the HLT pending flag.

@mmusich Thanks a lot, Marco!

…emplate reco failures. Also cleanup naming of some pixel CPE configuration parameters

…o's fail without track angles

cmsbuild · 2021-05-20T10:46:33Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1aee1/15201/summary.html
COMMIT: 0025d48
CMSSW: CMSSW_11_3_X_2021-05-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33792/15201/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3934 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877046
DQMHistoTests: Total failures: 38196
DQMHistoTests: Total nulls: 2
DQMHistoTests: Total successes: 2838826
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-05-20T10:51:39Z

Pull request #33792 was updated. @perrotta, @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @fwyzard, @kpedro88, @Martin-Grunewald, @srimanob, @tlampen, @slava77, @jpata, @cmsbuild, @pohsun, @francescobrivio can you please check and sign again.

cmsbuild · 2021-05-20T10:54:40Z

Pull request #33792 was updated. @perrotta, @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @tlampen, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @pohsun, @francescobrivio can you please check and sign again.

mmusich · 2021-05-20T10:56:20Z

@cmsbuild, please test

cmsbuild · 2021-05-27T14:06:09Z

Pull request #33792 was updated. @perrotta, @malbouis, @yuanchao, @jordan-martins, @chayanit, @wajidalikhan, @tlampen, @kpedro88, @cmsbuild, @srimanob, @slava77, @jpata, @pohsun, @francescobrivio can you please check and sign again.

mmusich · 2021-05-27T14:06:41Z

@cmsbuild, please test

cmsbuild · 2021-05-27T17:10:52Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1aee1/15362/summary.html
COMMIT: 64ab2c3
CMSSW: CMSSW_11_3_X_2021-05-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33792/15362/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6768 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2877742
DQMHistoTests: Total failures: 21639
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2856080
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: found differences in 1 / 37 workflows

slava77 · 2021-05-27T17:26:18Z

+reconstruction

for #33792 64ab2c3

code changes are in line with the PR description and the follow up review
- the backport from Update template and gen errors for phase-2 geometries with 3D pixels #33508 is exact; the backport from Use Lorentz Angle from data base for pixel template CPE's in case of error #33495 has a technical difference to keep consistent support of the old HLT configurations
- physics changes in tracking affect all eras, but can be interpreted as a bugfix (although the fix is for a part of the code that was present for a few release cycles and would nominally be described as a feature update)
jenkins tests pass and comparisons with the baseline show small differences which start in tracks and propagate downstream to dependent values
- the last test of this PR also includes a large set of differences in wf 11634.911, which is known to be non-repeatable at the SIM step and can be ignored

srimanob · 2021-05-28T08:07:06Z

+Upgrade

(re-sign)

srimanob · 2021-05-28T08:07:47Z

@cms-sw/alca-l2 @cms-sw/pdmv-l2 Could you please and comment? We expect this to be in the next 11_3 release by early next week. Thanks.

tlampen · 2021-05-28T15:11:33Z

+alca

Backport of #33508 (see comments therein) and #33495 (bugfix), both fully signed.

qliphy · 2021-05-29T03:56:18Z

@cms-sw/pdmv-l2 Kindly ping. The next 11_3 release will be made by early next week, and this PR is needed.

qliphy · 2021-05-29T03:56:37Z

urgent

chayanit · 2021-05-29T05:32:37Z

+1

cmsbuild · 2021-05-29T05:33:01Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-05-29T05:59:50Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone May 20, 2021

cmsbuild added alca-pending hlt-pending orp-pending pdmv-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 20, 2021

cmsbuild added tests-started and removed tests-pending labels May 20, 2021

Martin-Grunewald reviewed May 20, 2021

View reviewed changes

OzAmram and others added 5 commits May 20, 2021 10:54

Change pixel CPE template reco's to use LA value from DB in case of t…

1be9a15

…emplate reco failures. Also cleanup naming of some pixel CPE configuration parameters

Update HLT configs to match new pixel CPE parameters

4d3f8c3

Update HLT customisation function name to refer to PR number

1d541ae

Cleanup CPE ES producers and don't use loc_trk_pred when template rec…

2999351

…o's fail without track angles

Update template and gen errors for geometries with 3D pixels

4b14c61

cmsbuild added tests-approved and removed tests-started labels May 20, 2021

mmusich force-pushed the combineBackportOf33495And33508 branch from 0025d48 to 00c6104 Compare May 20, 2021 10:51

cmsbuild added tests-pending and removed tests-approved labels May 20, 2021

mmusich force-pushed the combineBackportOf33495And33508 branch from 00c6104 to 2044fd5 Compare May 20, 2021 10:54

cmsbuild removed the hlt-pending label May 20, 2021

cmsbuild added tests-started and removed tests-pending labels May 27, 2021

cmsbuild added tests-approved and removed tests-started labels May 27, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels May 27, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels May 28, 2021

cmsbuild added alca-approved and removed alca-pending labels May 28, 2021

cmsbuild added the urgent label May 29, 2021

cmsbuild added fully-signed pdmv-approved and removed pdmv-pending pending-signatures labels May 29, 2021

cmsbuild added orp-approved and removed orp-pending labels May 29, 2021

cmsbuild merged commit 44fbf0c into cms-sw:CMSSW_11_3_X May 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase-2 Inner Tracker: combined backport of 33495 and 33508 #33792

Phase-2 Inner Tracker: combined backport of 33495 and 33508 #33792

mmusich commented May 20, 2021 •

edited

Loading

cmsbuild commented May 20, 2021

mmusich commented May 20, 2021

Martin-Grunewald May 20, 2021

mmusich May 20, 2021

Martin-Grunewald May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

mmusich commented May 20, 2021

cmsbuild commented May 27, 2021

mmusich commented May 27, 2021

cmsbuild commented May 27, 2021

slava77 commented May 27, 2021

srimanob commented May 28, 2021

srimanob commented May 28, 2021

tlampen commented May 28, 2021

qliphy commented May 29, 2021

qliphy commented May 29, 2021

chayanit commented May 29, 2021

cmsbuild commented May 29, 2021

qliphy commented May 29, 2021

		@@ -129,11 +129,26 @@ def customiseFor2018Input(process):

		return process

		def customiseFor33495(process):

Phase-2 Inner Tracker: combined backport of 33495 and 33508 #33792

Phase-2 Inner Tracker: combined backport of 33495 and 33508 #33792

Conversation

mmusich commented May 20, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 20, 2021

mmusich commented May 20, 2021

Martin-Grunewald May 20, 2021

Choose a reason for hiding this comment

mmusich May 20, 2021

Choose a reason for hiding this comment

Martin-Grunewald May 20, 2021

Choose a reason for hiding this comment

cmsbuild commented May 20, 2021

Comparison Summary

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

mmusich commented May 20, 2021

cmsbuild commented May 27, 2021

mmusich commented May 27, 2021

cmsbuild commented May 27, 2021

Comparison Summary

slava77 commented May 27, 2021

srimanob commented May 28, 2021

srimanob commented May 28, 2021

tlampen commented May 28, 2021

qliphy commented May 29, 2021

qliphy commented May 29, 2021

chayanit commented May 29, 2021

cmsbuild commented May 29, 2021

qliphy commented May 29, 2021

mmusich commented May 20, 2021 •

edited

Loading