Making miniAOD low pt tracks threshold tunable

[AdrianoDee]

This PR make configurable the minimun pT for a track to be stored with a reduced precision covariance matrix, previously hard coded to be 0.5 GeV. In order to make also the latter configurable at run time a new variable minPtForLowQualityTrackProperties is defined in PATPackedCandidateProducer. This is also added to PATLostTracks with minPtToStoreLowQualityProps.

The further proposal is to lower it to 0.0 GeV for PATPackedCandidateProducer. The impact on miniAOD format size is in the range of 2.5-4.5 % (depending on PU).

The relative size increase is checked on a a set of Run3 ttbar samples with multiple < PU >:

The size per event:

The withBS shown here refers to the addition of offlineSlimmedPrimaryVerticesWithBS as in #33778

Further checks in the references below.

PR Validation and Further references

BPH Jamboree December 2020 here

xPOG Meeting February 2021 here

Further reference here

For a complete documentation, trk4bph meetings: 1, 2, 3 , 4, 5, 6

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33777/22744

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @swozniewski, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[slava77]

assign xpog

[cmsbuild]

New categories assigned: xpog

@fgolf,@mariadalfonso,@gouskos you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5db3db/15184/summary.html
COMMIT: 071f728
CMSSW: CMSSW_12_0_X_2021-05-18-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33777/15184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3686 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 2226
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2645994
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33777/22754

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #33777 was updated. @perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please check and sign again.

[AdrianoDee]

@slava77 sorry pushed a wrong commit (and reverted it).

[slava77]

@cmsbuild please test

[slava77]

e.g. in reminiAOD of 2018, wf 136.88811

presence of detailed information impacts the algorithms downstream which rely on these track details. tau ID and b-tags change in a somewhat minor way.

the miniAOD file in jenkins/bot outputs changes in size (100 evts) : 10446585 B -> 10686017 B : 2.3% increase, consistent with the details in the PR description.

[slava77]

+reconstruction

for #33777 0cbab0b

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show differences in miniAOD, starting from more track details; Making miniAOD low pt tracks threshold tunable #33777 (comment)
  • the observation is based on 071f728, which has identical code changes to 0cbab0b

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5db3db/15224/summary.html
COMMIT: 0cbab0b
CMSSW: CMSSW_12_0_X_2021-05-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33777/15224/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3694 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 2231
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648232
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1