Migrate PF modules to esConsumes

[marksan87]

PR description:

Migration of remaining RecoParticleFlow packages to esConsumes to address #31061

PR validation:

Run standard limited matrix evaluation

runTheMatrix.py -l limited -j 8 --ibeos

@hatakeyamak @laurenhay @bendavid @rappoccio

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22537

• This PR adds an extra 404KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22537/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22537/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22538

• This PR adds an extra 236KB to repository

[cmsbuild]

A new Pull Request was created by @marksan87 (Mark Saunders) for master.

It involves the following packages:

RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFClusterTools
RecoParticleFlow/PFProducer
RecoParticleFlow/PFSimProducer

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @cbernet, @rovere, @lgray, @clelange, @lecriste, @hatakeyamak, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc98f/14926/summary.html
COMMIT: b046f9c
CMSSW: CMSSW_12_0_X_2021-05-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33652/14926/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2662646
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2662623
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

Please find below a few comments collected from a visual inspection of the code

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22681

• This PR adds an extra 220KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22681/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22681/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33652/22684

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #33652 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[marksan87]

@perrotta Thanks for the feedback. These changes have been incorporated in the last commit.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc98f/15110/summary.html
COMMIT: 899874f
CMSSW: CMSSW_12_0_X_2021-05-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33652/15110/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2648242
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2648207
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[perrotta]

There are a couple of tiny differences (like numerical fluctuations) in the nanoAOD workflow 1325.81:

Does anybody (e.g. @cms-sw/xpog-l2 ) knows from where they can be originated? As I said, they look like being originated by some numerical fluctuation due to some different precision applied in the code, or some difference in the order of calculations,, but it wouldn't be bad to understand what caused them before approving.

They weren't present before the last changes, but unfortunately the last updates do not seem having been factorized into a single commit, as some reshuffle has been applied: @marksan87 did you manage to save somewhere the differences wrt the previous version of this PR?

[mariadalfonso]

@perrotta

I do not think these differences are associated to the changes in this PR.

The tau change is known #32628 and shows up often.
There is also a small numerical difference showing up in the NanoPlots of DeepMET time to time.
The particleNet is new to me, but fall in the same categories of the two cases above and are related to the ML inputs.

[perrotta]

+1

• Technical migration, as planned, plus some code cleaning: there are now no more related warnings from the static analyzer
• Jenkins tests pass and show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1