-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only 1 thread when testing EventProcessor #33549
Conversation
Explicitly call tbb::global_control in unit tests.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33549/22330
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ef87e6/14641/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Differences are in DD4Hep (#33552), MessageLogger, and apparently a new irreproducibility in DQM histogram EgammaV/ElectronMcSignalValidatorMiniAOD/h_ele_neutralHadronRelativeIso_mAOD_recomp in workflows 10024.0 and 10224.0. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Explicitly call tbb::global_control in unit tests.
PR validation:
Code compiles and the tests pass. Running under gdb shows no additional threads happening during test (although TBB does start a few up when tbb::global_control is deleted).
fixes cms-sw/framework-team#136