Change input collection for genVisTaus (106X)

[mbluj]

As title says: input collection of genParticles used to build genVisTaus is changed from prunedGenParticles (miniAOD collection) to finalGenParticles (nanoAOD collection) to ensure consistency with other genParticle-based information stored in nanoAOD, in particular to make mother indices working properly.
The change is deactivated for old nanoAOD eras to ensure backward compatibility.

Expected changes:

• indices of mother particles of genVisTaus are correctly set,
• marginal impact on produced genVisTaus - with the new setup there is ~4/10000 less genVisTaus than with previous setup which is acceptable (tested with DY sample).

This fixes issue cms-nanoAOD#486.

It is a backport of #33522 to 106X for nanoAODv9 production.

PR validation:

Change tested with a custom workflow with DYJetsToLL sample from Summer20UL production.
Matrix tests (runTheMatrix.py -l limited -i all --ibeos) successful.

if this PR is a backport please specify the original PR and why you need to backport that PR:

It is a backport of #33522 to 106X for nanoAODv9 production.

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[gouskos]

please test

[mariadalfonso]

@mbluj
the no change policy apply only to the run2_nanoAOD_106Xv1
as V8nano is the only production we have ongoing with 10_6_X

to safeguard the current ongoing v8 production in 10_6_X
(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(xyzTable , xyxVariable = None)

[mbluj]

@mbluj
the no change policy apply only to the run2_nanoAOD_106Xv1
as V8nano is the only production we have ongoing with 10_6_X

to safeguard the current ongoing v8 production in 10_6_X
(run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel).toModify(xyzTable , xyxVariable = None)

Thanks. To be sure if I understand it correctly - should I replace the full "inactivation" list (run2_nanoAOD_92X | run2_nanoAOD_94X2016 | run2_nanoAOD_94XMiniAODv1 | run2_nanoAOD_94XMiniAODv2 | run2_nanoAOD_102Xv1 | run2_nanoAOD_106Xv1 | run2_nanoAOD_106Xv2) by (run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel)? Is it correct?

[cmsbuild]

Pull request #33525 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mbluj]

Hi,
"inactivation" of the changes for past eras limited to (run2_nanoAOD_106Xv1 & ~run2_nanoAOD_devel) only as requested in the recent comment;

[cmsbuild]

Pull request #33525 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

backport

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-007c9e/14595/summary.html
COMMIT: b760b8a
CMSSW: CMSSW_10_6_X_2021-04-26-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33525/14595/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1229 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215541
• DQMHistoTests: Total failures: 2040
• DQMHistoTests: Total nulls: 22
• DQMHistoTests: Total successes: 3213145
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 56.705 KiB( 34 files compared)
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 10.938 KiB Info/EventInfo
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 140.53 ): 0.064 KiB SiStrip/MechanicalView
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

inline with master
nanoV8 updates protected via modifier

[mariadalfonso]

backport

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

comparison diff are due to change in input dataset file

[qliphy]

+1