Hit counters for Run-3 shower CSC trigger (HadronicShowerTrigger-2) #33416

dildick · 2021-04-13T02:33:23Z

PR description:

This PR adds the code to count cathode/anode hits and packs the result in a CSCShowerDigi object. Follow-up of #33389. The hit counters are not enabled yet.

PR validation:

Code compiles. The hit counters run parallel with the ordinary ALCT and CLCT finding. Tested with WF 11634.0. There should be no differences.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A. We expect the (local trigger, track-finder, uGMT) firmware to be available by Summer 2021. I'll first develop the entire emulator in 11_3_X, then backport if need be.

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2021-04-13T02:40:18Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33416/22062

ERROR: Build errors found during clang-tidy run.

Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h:40:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigi.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigi.h"
         ^
Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h:40:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigi.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigi.h"
         ^
Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCTriggerPrimitivesBuilder.h:30:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h"
         ^
Suppressed 361 warnings (360 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCTriggerPrimitivesBuilder.h:30:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h"
         ^
Suppressed 814 warnings (813 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

dildick · 2021-04-13T02:50:32Z

I tried rebasing to see if this would remove the clang error.

cmsbuild · 2021-04-13T02:55:11Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33416/22063

ERROR: Build errors found during clang-tidy run.

Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h:40:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigi.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigi.h"
         ^
Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h:40:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigi.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigi.h"
         ^
Suppressed 352 warnings (351 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCTriggerPrimitivesBuilder.h:30:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h"
         ^
Suppressed 361 warnings (360 in non-user code, 1 with check filters).
--
L1Trigger/CSCTriggerPrimitives/interface/CSCTriggerPrimitivesBuilder.h:30:10: error: 'DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h' file not found [clang-diagnostic-error]
#include "DataFormats/CSCDigi/interface/CSCShowerDigiCollection.h"
         ^
Suppressed 814 warnings (813 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

dildick · 2021-04-13T03:00:44Z

Strange, the CSCShowerDigiCollection is present in the 11_3_X branch though.

cmsbuild · 2021-04-13T15:58:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33416/22090

This PR adds an extra 24KB to repository

cmsbuild · 2021-04-13T15:58:45Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

dildick · 2021-04-14T16:17:06Z

@cecilecaillol Could you start the tests, please?

cecilecaillol · 2021-04-14T16:18:19Z

please test

cmsbuild · 2021-04-14T17:39:32Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c8c48/14237/summary.html
COMMIT: 122a409
CMSSW: CMSSW_11_3_X_2021-04-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33416/14237/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.793

----- Begin Fatal Exception 14-Apr-2021 18:34:35 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing  Event run: 301998 lumi: 9 event: 8792128 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

136.874136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log
136.731136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

Expand to see more relval errors ...

RelVals-INPUT

6.06.0_SingleMuPt1+SingleMuPt1INPUT+DIGI+RECO+HARVEST/step2_SingleMuPt1+SingleMuPt1INPUT+DIGI+RECO+HARVEST.log
12.012.0_ZpMM+ZpMMINPUT+DIGI+RECO+HARVEST/step2_ZpMM+ZpMMINPUT+DIGI+RECO+HARVEST.log
20.020.0_SingleMuPt10+SingleMuPt10INPUT+DIGI+RECO+HARVEST/step2_SingleMuPt10+SingleMuPt10INPUT+DIGI+RECO+HARVEST.log

Expand to see more relval errors ...

AddOn Tests

fastsim

----- Begin Fatal Exception 14-Apr-2021 18:37:22 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 3
   [1] Running path 'L1Reco_step'
   [2] Prefetching for module L1ExtraParticlesProd/'l1extraParticles'
   [3] Prefetching for module L1MuGlobalMuonTrigger/'simGmtDigis'
   [4] Prefetching for module DTTrackFinder/'simDttfDigis'
   [5] Prefetching for module CSCTFTrackProducer/'simCsctfTrackDigis'
   [6] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 14-Apr-2021 18:36:34 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 0
   [1] Running path 'L1TAnalyzerEndpath'
   [2] Prefetching for module L1TGlobalSummary/'L1TGlobalSummary'
   [3] Prefetching for module L1TGlobalProducer/'simGtStage2Digis'
   [4] Prefetching for module L1TMuonProducer/'simGmtStage2Digis'
   [5] Prefetching for module L1TMuonOverlapTrackProducer/'simOmtfDigis'
   [6] Calling method for module CSCTriggerPrimitivesProducer/'simCscTriggerPrimitiveDigis'
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

fastsim1cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Wed Apr 14 18:38:39 2021-date Wed Apr 14 18:34:00 2021 s - exit: 35584

Expand to see more addon errors ...

cmsbuild · 2021-04-15T01:53:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33416/22114

This PR adds an extra 88KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/CSCTriggerPrimitives/interface/CSCAnodeLCTProcessor.h modified in PR(s): Use CSCConstants in CSC trigger, packer, unpacker and track-finders #33429
- File L1Trigger/CSCTriggerPrimitives/interface/CSCBaseboard.h modified in PR(s): Use CSCConstants in CSC trigger, packer, unpacker and track-finders #33429
- File L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc modified in PR(s): Use CSCConstants in CSC trigger, packer, unpacker and track-finders #33429
- File L1Trigger/CSCTriggerPrimitives/src/CSCCathodeLCTProcessor.cc modified in PR(s): Use CSCConstants in CSC trigger, packer, unpacker and track-finders #33429

cmsbuild · 2021-04-15T01:54:24Z

Pull request #33416 was updated. @cmsbuild, @rekovic, @cecilecaillol can you please check and sign again.

cecilecaillol · 2021-04-15T07:18:37Z

please test

cmsbuild · 2021-04-15T10:01:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c8c48/14252/summary.html
COMMIT: a8098ce
CMSSW: CMSSW_11_3_X_2021-04-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33416/14252/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 38
DQMHistoTests: Total histograms compared: 2864426
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2864397
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 160 log files, 37 edm output root files, 38 DQM output files
TriggerResults: no differences found

cecilecaillol · 2021-04-15T10:05:04Z

+l1

cmsbuild · 2021-04-15T10:05:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

dildick · 2021-04-15T11:41:19Z

6 failures, 5 from the message logger, 1 from the pixel system.

dildick · 2021-04-15T16:10:43Z

Are there any more comments on this PR?

dildick · 2021-04-16T15:21:12Z

@qliphy can this be signed off?

qliphy · 2021-04-16T15:40:37Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone Apr 13, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Apr 13, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Apr 13, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 13, 2021

Sven Dildick added 2 commits April 13, 2021 10:52

Change nodigis to hasdigis

b633533

Hit counter for shower trigger

122a409

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 13, 2021

cmsbuild mentioned this pull request Apr 14, 2021

Use CSCConstants in CSC trigger, packer, unpacker and track-finders #33429

Merged

cmsbuild added tests-started and removed tests-pending labels Apr 14, 2021

cmsbuild added code-checks-pending and removed code-checks-rejected labels Apr 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 15, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 15, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 15, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Apr 15, 2021

cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_12_0_X Apr 15, 2021

cmsbuild mentioned this pull request Apr 16, 2021

Load CLCT pre-trigger digis in CSC packer. Skeleton code to pack/unpack CSCShowerDigi (HadronicShowerTrigger-3) #33444

Merged

cmsbuild added orp-approved and removed orp-pending labels Apr 16, 2021

cmsbuild merged commit ebbf48c into cms-sw:master Apr 16, 2021

dildick deleted the from-CMSSW_11_3_X_2021-04-12-1100-hit-counter-shower-trigger branch April 16, 2021 15:42

dildick mentioned this pull request Nov 6, 2021

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hit counters for Run-3 shower CSC trigger (HadronicShowerTrigger-2) #33416

Hit counters for Run-3 shower CSC trigger (HadronicShowerTrigger-2) #33416

dildick commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

dildick commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

dildick commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

dildick commented Apr 14, 2021

cecilecaillol commented Apr 14, 2021

cmsbuild commented Apr 14, 2021

cmsbuild commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

cecilecaillol commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

cecilecaillol commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

dildick commented Apr 15, 2021

dildick commented Apr 15, 2021

dildick commented Apr 16, 2021

qliphy commented Apr 16, 2021

Hit counters for Run-3 shower CSC trigger (HadronicShowerTrigger-2) #33416

Hit counters for Run-3 shower CSC trigger (HadronicShowerTrigger-2) #33416

Conversation

dildick commented Apr 13, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Apr 13, 2021

dildick commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

dildick commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

cmsbuild commented Apr 13, 2021

dildick commented Apr 14, 2021

cecilecaillol commented Apr 14, 2021

cmsbuild commented Apr 14, 2021

RelVals

RelVals-INPUT

AddOn Tests

cmsbuild commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

cecilecaillol commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

Comparison Summary

cecilecaillol commented Apr 15, 2021

cmsbuild commented Apr 15, 2021

dildick commented Apr 15, 2021

dildick commented Apr 15, 2021

dildick commented Apr 16, 2021

qliphy commented Apr 16, 2021