-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx281 Compare DDD against DD4Hep scenario for 2026D76 scenario #33379
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33379/21969
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33379/21970
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a982b/14147/summary.html Comparison SummarySummary:
|
+1 |
Hi @bsunanda |
@srimanob We have been struggling to find the reason of failure of Phase2 scenario in dd4hep. We use different codes for the algorithms and the main purpose of this PR is to see if the 2 sets of algorithms used for V14 HGCal give the same results. There are debug statements which are made similar outputs. Running the codes separately for silicon cells, wafers, full silicon layers, mixed layers and comparing the two sets of outputs using diff show identical results from ddd and dd4hep. This required changes in the debug statements, defining a few cdi's, cfg's which are parts of this PR |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Compare DDD against DD4Hep scenario for 2026D76 scenario. Used in testing the geometry through detailed printouts
PR validation:
Compared the workflow 34634 with DDD and DD4Hep
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special