[HGCAL] Update TICL iterations naming

[lecriste]

PR description:

This PR updates the itername attribute to the latest HGCAL naming, and removes the corresponding hard-coded lists in Validation. No changes are expected in the output, except for the naming.

PR validation:

runTheMatrix -l limited

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33336/21894

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): [HGCAL] TICL SimTracksters #33318
  • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): [HGCAL] TICL SimTracksters #33318, MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): [HGCAL] TICL SimTracksters #33318

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

RecoHGCal/TICL
Validation/HGCalValidation

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @srimanob, @jfernan2, @kpedro88, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[rovere]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ce009/14007/summary.html
COMMIT: 46ca254
CMSSW: CMSSW_11_3_X_2021-04-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33336/14007/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 135.4135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step2_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
• 5.15.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log
• 136.8311136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step3_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

Expand to see more relval errors ...

• 136.7611
• 136.88811
• 136.8523
• 4.22
• 8.0
• 7.3
• 140.53
• 158.01
• 9.0
• 1306.0
• 1325.81
• 312.0
• 1330.0
• 25.0
• 4.53
• 1000.0
• 136.731
• 10042.0
• 10024.0
• 10824.0
• 25202.0
• 136.793
• 11634.0
• 12434.0
• 136.874
• 10224.0
• 23234.0
• 34634.0
• 28234.0
• 140.56
• 250202.181
• 34834.999

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33336/21904

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): [HGCAL] TICL SimTracksters #33318
  • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): [HGCAL] TICL SimTracksters #33318, MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py modified in PR(s): [HGCAL] TICL SimTracksters #33318

[cmsbuild]

Pull request #33336 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @srimanob, @jfernan2, @kpedro88, @slava77, @jpata, @rvenditti can you please check and sign again.

[rovere]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ce009/14017/summary.html
COMMIT: 6a889d4
CMSSW: CMSSW_11_3_X_2021-04-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33336/14017/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2640868
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2640839
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[lecriste]

@cms-sw/dqm-l2 can you please review this PR?

[jfernan2]

+1

[lecriste]

@cms-sw/reconstruction-l2 can you please review this PR?

[slava77]

+reconstruction

for #33336 6a889d4

• code changes are in line with the PR description
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[lecriste]

@cms-sw/upgrade-l2 can you please review this PR?

[srimanob]

+Upgrade

Changing on iteration namings, mostly technical, no change is expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1