One more fix on the indexing of VFATs in GEM onlineDQM, a backport to CMSSW_11_2_X

[quark2]

PR description:

We modified the structure of GEM onlineDQM in the last time (#32791, #32792), and this is a fix for an issue on the indexing of VFATs, as like #33193. No fix on DQM GUI is necessary for this.

This is a backport of #33295 to CMSSW_11_2_X.

PR validation:

Test are done and one can check again by runTheMatrix workflows

[cmsbuild]

A new Pull Request was created by @quark2 for CMSSW_11_2_X.

It involves the following packages:

DQM/GEM

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[jfernan2]

Thanks @quark2
Is this needed in the next MWGR?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-381c16/13858/summary.html
COMMIT: 1a37717
CMSSW: CMSSW_11_2_X_2021-03-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33296/13858/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2527501
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2527466
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files
• TriggerResults: no differences found

[quark2]

Hi @jfernan2,

Right. Sorry for this late one, I should find it faster... Can it be implemented to the upcoming MWGR...?

Best regards,
Byeonghak Ko

[qliphy]

Right. Sorry for this late one, I should find it faster... Can it be implemented to the upcoming MWGR...?

The PR timeline towards MWGR#3 (14-16 April) is as below

• 30 Mar: PRs ready in 11_3_X
• 6 Apr: PRs merged in 11_2_X

Please move forward the master PR #33295 soon.
@quark2 @jfernan2
Thanks!

[quark2]

Hi @qliphi,

Then should I close #33295 and PR again a few days later?

Best regards,
Byeonghak Ko

[qliphy]

@quark2 No need to close #33295. Let's see how fast we can move forward.

[jfernan2]

+1
Tested at Online DQM@P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1