-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of outdated paths from HLT Exotica Validation #33273
Conversation
…iki/bin/view/CMS/IssuesExoticaHLTValidation#HLT_paths_not_up_to_date); addition of hltExoticaPostSingleMuon inside the hltExoticaPostProcessors Sequence (at the bottom of the file; the plots for this category were not being produced)
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33273/21770
|
A new Pull Request was created by @borzari for master. It involves the following packages: HLTriggerOffline/Exotica @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-039f41/13779/summary.html Comparison SummarySummary:
|
@borzari despite the cleanup and commenting of HLT paths, no real reduction or modification of plots is produced, is this expected? |
@jfernan2 yes, it is expected since the paths that were commented are outdated and no longer exist in the current HLT menus. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This is a cleanup of outdated paths from the HLT Exotica Validation code. The list of these paths can be found in https://twiki.cern.ch/twiki/bin/view/CMS/IssuesExoticaHLTValidation#HLT_paths_not_up_to_date ; addition of hltExoticaPostSingleMuon inside the hltExoticaPostProcessors Sequence (at the bottom of the file; the efficiency plots for this category were not being produced).
The code was tested using local files and showed no issues (as expected); the single muon category paths efficiency plots are now being created; The command
runTheMatrix.py -l limited -i all --ibeos
was run with success.