Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of outdated paths from HLT Exotica Validation #33273

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Cleanup of outdated paths from HLT Exotica Validation #33273

merged 1 commit into from
Mar 30, 2021

Conversation

borzari
Copy link
Contributor

@borzari borzari commented Mar 25, 2021

This is a cleanup of outdated paths from the HLT Exotica Validation code. The list of these paths can be found in https://twiki.cern.ch/twiki/bin/view/CMS/IssuesExoticaHLTValidation#HLT_paths_not_up_to_date ; addition of hltExoticaPostSingleMuon inside the hltExoticaPostProcessors Sequence (at the bottom of the file; the efficiency plots for this category were not being produced).

The code was tested using local files and showed no issues (as expected); the single muon category paths efficiency plots are now being created; The command runTheMatrix.py -l limited -i all --ibeos was run with success.

…iki/bin/view/CMS/IssuesExoticaHLTValidation#HLT_paths_not_up_to_date); addition of hltExoticaPostSingleMuon inside the hltExoticaPostProcessors Sequence (at the bottom of the file; the plots for this category were not being produced)
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33273/21770

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @borzari for master.

It involves the following packages:

HLTriggerOffline/Exotica

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-039f41/13779/summary.html
COMMIT: a27c112
CMSSW: CMSSW_11_3_X_2021-03-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33273/13779/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2639935
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2639906
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 12.628 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 6.312 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@borzari despite the cleanup and commenting of HLT paths, no real reduction or modification of plots is produced, is this expected?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_3_X_2021-03-25-1100+039f41/41896/dqm-histo-comparison-summary.html

@borzari
Copy link
Contributor Author

borzari commented Mar 29, 2021

@jfernan2 yes, it is expected since the paths that were commented are outdated and no longer exist in the current HLT menus.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 30, 2021

+1

@cmsbuild cmsbuild merged commit 9c73b95 into cms-sw:master Mar 30, 2021
@borzari borzari deleted the borzari branch March 30, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants