Small fixes on HGCAL Validation code

[ebrondol]

PR description:

This PR aims to include a couple of fixes in the HGCal validation code:

• Now TrkEM is included in the Validator
• Neutral kaons are inserted in the selected CaloParticles
• The CaloParticles are now selected correctly with the fix on the order of the variables. This fix can change some lots of the HGCal validation.

PR validation:

• Code checks and format passed
• WF n23288.0 SinglePiPt25Eta1p7_2p7 run successfully without changes

Informing @apsallid @lecriste @rovere @felicepantaleo

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33271/21767

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/HGCalValidation/plugins/HGCalValidator.cc modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/python/HGCalValidator_cfi.py modified in PR(s): MultiCluster-CaloParticle associator #32941
  • File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): MultiCluster-CaloParticle associator #32941

[cmsbuild]

A new Pull Request was created by @ebrondol (Erica Brondolin) for master.

It involves the following packages:

Validation/HGCalValidation
Validation/RecoTrack

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @makortel, @felicepantaleo, @wmtford, @GiacomoSguazzoni, @JanFSchulte, @rovere, @lgray, @cseez, @apsallid, @pfs, @lecriste, @hatakeyamak, @VinInn, @mtosi, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-09e28a/13766/summary.html
COMMIT: 12bf8d6
CMSSW: CMSSW_11_3_X_2021-03-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33271/13766/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 4723
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2635189
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 5090.568 KiB( 36 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 1272.641 KiB HGCAL/HGCalValidator
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1
cc @cms-sw/upgrade-l2