-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esConsumes migration of HLTrigger/ #33260
esConsumes migration of HLTrigger/ #33260
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33260/21743
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages: HLTrigger/Egamma @Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9c5e6/13745/summary.html Comparison SummarySummary:
|
Great stuff, @missirol , thanks a lot! |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This is a technical PR to address #31061 for the packages under
HLTrigger/
.I'm not entirely sure I got all of them; experts could maybe suggest how to check this, if needed.
For some producers, some cleanup of
#include
statements was also done.PR validation:
Passed a limited set of workflows with
runTheMatrix.py
.If this PR is a backport, please specify the original PR and why you need to backport that PR:
N/A