Conditions classes for Ecal Trigger double weights mechanism

[valsdav]

PR description:

The Ecal trigger team is working on a double weights mechanism for the trigger primitive generation.
This PR introduces the necessary condition classes for the CondDB.

• EcalTPGOddWeight IdMap and Group classes: essentially a clone of the standard weight classes
• EcalTPGTPMode class: a new record to handle the configuration of the double weights mechanism. This class will be added also in the online DB and O2O script will be provided in a subsequent PR.

Details about the format of the new DB classes can be found in slide 10 and 11 of this presentation [1]
A follow-up PR will be prepared for the changes to the Ecal Trigger emulator and O2O scripts.

This PR should not change any output.

The PR also adds the xml dump capability for the mustache SC parameters and the dynamic dPhi parameters.

PR validation:

Test payloads have been already uploaded by ECAL experts in the ProdDB for the tags following tags:

• EcalTPGTPMode_v2_hlt (same as Run2_default)
• EcalTPG_TPMode_Run2_default_v0
• EcalTPG_TPMode_Run3_zeroing_v0
• EcalTPGOddWeightIdMap_v2_hlt
• EcalTPGOddWeightGroup_v2_hlt
• EcalTPGOddWeightGroup_v0
• EcalTPGOddWeightIdMap_v0

The EcalTPG_TPMode_Run2_default_v0 tag corresponds to the standard Run2 configuration that will be used for back-compability in the new Ecal TPG emulator.

---

[1] https://indico.cern.ch/event/991259/contributions/4257032/attachments/2201014/3722716/21_03_03%20-%20L1%20double%20weight%20CMSSW%20integration.pdf

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33220/21662

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33220/21662/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33220/21662/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33220/21664

• This PR adds an extra 60KB to repository

[cmsbuild]

A new Pull Request was created by @valsdav (Davide Valsecchi) for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
CondCore/EcalPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/EcalObjects

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c57a42/13645/summary.html
COMMIT: 786a88b
CMSSW: CMSSW_11_3_X_2021-03-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33220/13645/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639900
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[francescobrivio]

• Looking at the comparison I see failures in the MessageLogger for WFs 25202.0 and 10224.0, not sure if these were expecetd.
• Also, there are errors in the Duplicate Dictionaries section of the tests, although I'm not sure what they are

[thomreis]

The MessageLogger failures seem to be coming from the mixing module, and, therefore, unrelated to the changes in this PR.
The log messages for the Duplicate Dictionaries errors suggest that those are related to track trigger and not the ECAL.

[francescobrivio]

+alca

• failures an differences in the tests are not related to this PR

[cecilecaillol]

+l1

[thomreis]

Hi @ggovi do you have any comments?

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[boudoul]

Hi @valsdav . I see in the linked presentation that you would like to test it in MWGR from May. I was wondering if you would like to already give a try to the next MWGR (April) ? Thanks.

@amassiro FYI.

[thomreis]

Hi @boudoul would we need to make a backport to 11_2 for the April MWGR or is it already going to be with the 11_3 release?

[boudoul]

Hi @thomreis , for April a backport is indeed needed .

[valsdav]

Hi @boudoul, @amassiro, since it it not critical for us to test the full chain in the April MWGR and we still need to complete the PR for the emulator, O2O scripts and the updated GT, we prefer to avoid backporting these changes and test the full chain in the next MWGR (in June). In the meanwhile we can continue anyway tests in P5 if needed and also re-emulate later the data with the modified emulator, so no problem for the developments.

Thanks
Davide