Annotate EventSetupImpl::taskArena() as thread safe

[makortel]

PR description:

This should silence many static analyzer warnings that @jpata reported in https://mattermost.web.cern.ch/cms-o-and-c/pl/6efrf7q4s7yi8k3oaamjhwdr3a

Resolves cms-sw/framework-team#85

PR validation:

Framework compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33218/21660

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e207ac/13621/summary.html
COMMIT: c13313b
CMSSW: CMSSW_11_3_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33218/13621/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test BUFU_TEST had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639912
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[makortel]

The unit test failure from the log

===== Test "BUFU_TEST" ====
argument 0: BUFU_TEST
argument 1: /bin/bash
argument 2: EventFilter/Utilities/test
argument 3: RunBUFU.sh
shell is: /bin/bash
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100
topdir is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100
testdir is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/src/EventFilter/Utilities/test
tmpdir is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/tmp/slc7_amd64_gcc900
testbin is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/test/slc7_amd64_gcc900
Running script: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/src/EventFilter/Utilities/test/RunBUFU.sh
LOCAL_TEST_DIR = /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/src/EventFilter/Utilities/test
LOCAL_TMP_DIR = /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/tmp/slc7_amd64_gcc900
Running test with index JSONs
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/src/EventFilter/Utilities/test/RunBUFU.sh: line 34: 22506 Segmentation fault      ${CMDLINE_STARTFU} > out_1_fu.log 2>&1
Failure cmsRun unittest_FU.py runNumber=101 fffBaseDir=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-19-1100/tmp/slc7_amd64_gcc900/results_cmsbld21745: status 139

----- Error -----

%MSG-i ThreadStreamSetup:  (NoModuleName) 19-Mar-2021 17:04:00 CET pre-events
setting # threads 2
setting # streams 2
%MSG
%MSG-s ModulesSynchingOnLumis:  AfterModConstruction 19-Mar-2021 17:04:10 CET  pre-events
The following modules require synchronizing on LuminosityBlock boundaries:
  ShmStreamConsumer streamC
%MSG
%MSG-e HLTConfigProvider:  HLTriggerJSONMonitoring:hltJson@beginRun  19-Mar-2021 17:04:10 CET Run: 101
Falling back to ProcessName-only init using ProcessName 'HLT' !
%MSG
%MSG-e HLTConfigProvider:  HLTriggerJSONMonitoring:hltJson@beginRun  19-Mar-2021 17:04:10 CET Run: 101
 Process name 'HLT' not found in registry!
%MSG
%MSG-e HLTriggerJSONMonitoring:  HLTriggerJSONMonitoring:hltJson@beginRun  19-Mar-2021 17:04:10 CET Run: 101
HLTConfigProvider initialization failed!
%MSG
status = 35584

---> test BUFU_TEST had ERRORS

I have hard time to believe this PR would be causing errors.

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e207ac/13633/summary.html
COMMIT: c13313b
CMSSW: CMSSW_11_3_X_2021-03-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33218/13633/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2639906
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1