-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop type spec and move sequence to task in CommonTools #33201
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33201/21626
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages: CommonTools/ParticleFlow @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fc13f/13567/summary.html Comparison SummarySummary:
|
pfTausDiscriminationByIsolation | ||
) | ||
pfTausBaseSequence = cms.Sequence(pfTausBaseTask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed now, maybe it can be cleaned up
pfTauTagInfoProducer | ||
) | ||
pfTausPreSequence = cms.Sequence(pfTausPreTask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed now, maybe it can be cleaned up
|
||
pfCorMET = cms.Sequence( pfRawMET * pfType1METChain ) | ||
pfCorMETTask = cms.Task( pfRawMET , pfType1METChain ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pfCorMETTask = cms.Task( pfRawMET , pfType1METChain ) | |
pfCorMETTask = cms.Task( pfRawMET , pfType1METChainTask ) |
(or, even better, remove L13 and rename pfType1METChainTask
as pfType1METChain
in L12)
phPFIsoValuePU04PFIdPFBRECO | ||
) | ||
photonPFIsolationValuesPFBRECOSequence = cms.Sequence(photonPFIsolationValuesPFBRECOTask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed any more, it can be removed
phPFIsoDepositPUPFBRECO | ||
) | ||
photonPFIsolationDepositsPFBRECOSequence = cms.Sequence(photonPFIsolationDepositsPFBRECOTask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed any more, it can be removed
) | ||
|
||
pfPhotonIsolationSequence = cms.Sequence(pfPhotonIsolationTask) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If one wants to clean up, one could now remove the definitions of photonPFIsolationDepositsSequence
and photonPFIsolationValuesSequence
from
- RecoParticleFlow/PFProducer/python/photonPFIsolationValues_cff.py
- RecoParticleFlow/PFProducer/python/photonPFIsolationDeposits_cff.py
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33201/21658
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6fc13f/13616/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Since the last commit only cleaned up from unused sequences, I take for good that there were no crashes (which confirms, if needed, that really those sequences weren't used anywhere), while I consider the previous comparison to certify that this PR doesn't originate any change in reco (or whatever) output. The comparisons in the current test are biased by the additional PRs run together, instead.
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
optimization of the python configurations :
In this PR, 25 files changed. (previous PRs for CommonTools is PR#32464 )
drop type specifications where the original parameter exists.
CommonTools/ParticleFlow/python/Isolation/ 5 files
CommonTools/PileupAlgos/python/ 1 file
move cms.Sequence() to cms.Task()
CommonTools/ParticleFlow/python/ 11 files
CommonTools/ParticleFlow/python/GeneratorTools/ 1 file
CommonTools/ParticleFlow/python/Isolation/ 7 files
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.