Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize variables to fix compiler warnings #33171

Merged
merged 1 commit into from
Mar 17, 2021
Merged

initialize variables to fix compiler warnings #33171

merged 1 commit into from
Mar 17, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Mar 13, 2021

UBSAN and LLVM 11 build show new build warnings about uninitialized variables. This PR show fix those warnings.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33171/21570

  • This PR adds an extra 24KB to repository

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondTools/Ecal
L1Trigger/TrackFindingTracklet

@ggovi, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@erikbutz, @rchatter, @argiro, @Martin-Grunewald, @thomreis, @simonepigazzini, @mmusich, @skinnari this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a0d3d/13486/summary.html
COMMIT: 3ccbf50
CMSSW: CMSSW_11_3_X_2021-03-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33171/13486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2635087
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2635058
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 155 log files, 37 edm output root files, 37 DQM output files

@smuzaffar smuzaffar changed the title initialize to fix compiler warnings initialize variables to fix compiler warnings Mar 13, 2021
@smuzaffar
Copy link
Contributor Author

@cms-sw/db-l2 , @cms-sw/l1-l2 can you please review and sign this. This is only to add the default initialization values

@rekovic
Copy link
Contributor

rekovic commented Mar 16, 2021

+1

@smuzaffar
Copy link
Contributor Author

@silviodonato , @qliphy this is to fix a compilation warning in clang IBs, can you please merge this?

@qliphy
Copy link
Contributor

qliphy commented Mar 17, 2021

+1

@cms-sw/db-l2 let's know if you have any concern.

@qliphy
Copy link
Contributor

qliphy commented Mar 17, 2021

merge

@cmsbuild cmsbuild merged commit ca9029f into cms-sw:master Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants