-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove boost/filesystem usage #33144
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33144/21509
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33144/21510
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages: CondCore/Utilities @perrotta, @smuzaffar, @andrius-k, @Dr15Jones, @makortel, @fwyzard, @emeschi, @ErnestaP, @ahmad3213, @Martin-Grunewald, @jpata, @cmsbuild, @jfernan2, @kmaeshima, @slava77, @ggovi, @smorovic, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-896f24/13434/summary.html Comparison SummarySummary:
|
+1 |
+1
|
+core |
+1 |
+1 |
kind reminder @ggovi @cms-sw/daq-l2 |
+1 |
ping @cms-sw/db-l2 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Cleanup boost/filesystem usage. With new boost version 1.75 , boost filesystem makes use of statx (if available on the build machine) and fails if run on a machine without it. The PR proposes to drop boost filesystem usage and replace it with std::filesystem