move TBB_PREVIEW_RESUMABLE_TASKS macro in tbb tool definition

[smuzaffar]

As suggested #32804 (comment) , the TBB_PREVIEW_RESUMABLE_TASKS macro should now be defined by tbb toolfile ( cms-sw/cmsdist#6713 ). This PR should be tested with cms-sw/cmsdist#6713

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33140/21501

ERROR: Build errors found during clang-tidy run.

FWCore/Concurrency/src/SerialTaskQueue.cc:34:18: error: no member named 'suspend' in 'tbb::task' [clang-diagnostic-error]
      tbb::task::suspend(
                 ^
FWCore/Concurrency/src/SerialTaskQueue.cc:35:33: error: no type named 'suspend_point' in 'tbb::task' [clang-diagnostic-error]
          [&g, this](tbb::task::suspend_point tag) { push(g, [tag]() { tbb::task::resume(tag); }); });  //suspend
                                ^
FWCore/Concurrency/src/SerialTaskQueue.cc:35:83: error: no type named 'resume' in 'tbb::task' [clang-diagnostic-error]
          [&g, this](tbb::task::suspend_point tag) { push(g, [tag]() { tbb::task::resume(tag); }); });  //suspend
                                                                                  ^
Suppressed 318 warnings (317 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[smuzaffar]

code-checks with cms.week1.PR_80e056b5/46.0-ac1ff7ae40402d0c60054be5c7760680

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33140/21503

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

FWCore/Concurrency

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test with cms-sw/cmsdist#6713

[smuzaffar]

please test with cms-sw/cmsdist#6713

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-774a58/13439/summary.html
COMMIT: 6d13b7d
CMSSW: CMSSW_11_3_X_2021-03-10-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33140/13439/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2635087
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2635064
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files

[smuzaffar]

+core
cms-sw/cmsdist#6713 is merged and TBB_PREVIEW_RESUMABLE_TASKS macro is now set by scram during the built time. This can be merged now

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1