If SecondaryEventProvider has no modules do not create a task

[Dr15Jones]

PR description:

edm::syncWait is always required to create at least one TBB task and then wait on it (which can cause other modules to be run on top of the module using SecondaryEventProvider). To avoid that in the case where there are no modules in SecondaryEventProvider we first check that condition and if so immediately return from the member functions.

This fixes the problem where the Timing service and the MessageLogger were both failing.

PR validation:

The code compiles and running step 1 of workflow 250406.17 using 4 threads, which was failing each time it was run, succeded 3 times in a row when run using the fix.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33125/21477

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Mixing/Base

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f7b2/13387/summary.html
COMMIT: 9461d3a
CMSSW: CMSSW_11_3_X_2021-03-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33125/13387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2849195
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2849164
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files

[Dr15Jones]

@cms-sw/simulation-l2 this is critical to fixing problems in the IB. Please review.

[smuzaffar]

@Dr15Jones ,should we try enabling threading tests for this PR?

[Dr15Jones]

Sure

[smuzaffar]

enable threading

[smuzaffar]

please test workflow 250406.17

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f7b2/13411/summary.html
COMMIT: 9461d3a
CMSSW: CMSSW_11_3_X_2021-03-09-2300/slc7_amd64_gcc900
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33125/13411/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-28f7b2/250406.17_ZMM_13+FS_ZMM_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2849195
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2849166
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files

[Dr15Jones]

@smuzaffar Looking at the testing output I see that '250406.17' was only run for the single threaded case, not the multi-threaded case.

[Dr15Jones]

So workflow 250202.181 is crashing in the IB but ran fine under the THREADING test for this pull request:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28f7b2/13411/runTheMatrixTHREADING-results/250202.181_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/

[smuzaffar]

@civanch, @mdhildreth can you please review this? This is critical to fix failures in IBs

[civanch]

+1

[smuzaffar]

@smuzaffar Looking at the testing output I see that '250406.17' was only run for the single threaded case, not the multi-threaded case.

you are right @Dr15Jones , threading job was only running runTheMatrix.py -s , I have fixed it and restarted the threading job only. Bot should update the results when https://cmssdt.cern.ch/jenkins/job/ib-run-pr-relvals/2081/ is done

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

@smuzaffar rerunning the test with that workflow is nice but not actually necessary. One of the workflows run in threading mode also exhibits the problem in the IB but worked fine here.

[smuzaffar]

@silviodonato , @qliphy , this is fully signed. Can we get this in IB ?

[qliphy]

+1