FileInPath: replace boost::filesystem by std::filesystem #33066
Conversation
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33066/21376
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33066/21377
|
|
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: FWCore/ParameterSet @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test
… On Mar 4, 2021, at 11:33 AM, cmsbuild ***@***.***> wrote:
A new Pull Request was created by @davidlange6 (David Lange) for master.
It involves the following packages:
FWCore/ParameterSet
@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
-1 Failed Tests: Build BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-03-2300/src/FWCore/PyDevParameterSet/test/makepset_t.cppunit.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_3_X_2021-03-03-2300/src/FWCore/PyDevParameterSet/test/readpsetsfrom_t.cppunit.cc >> Building binary testPyBind11ParameterSet /cvmfs/cms-ib.cern.ch/nweek-02670/slc7_amd64_gcc900/external/gcc/9.3.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/9.3.0/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc900/src/FWCore/PyDevParameterSet/test/testPyBind11ParameterSet/makepset_t.cppunit.cc.o: in function `testmakepset::fileinpathAux()': makepset_t.cppunit.cc:(.text+0x24aa): undefined reference to `boost::filesystem::detail::status(boost::filesystem::path const&, boost::system::error_code*)' collect2: error: ld returned 1 exit status >> Deleted: tmp/slc7_amd64_gcc900/src/FWCore/PyDevParameterSet/test/testPyBind11ParameterSet/testPyBind11ParameterSet gmake: *** [tmp/slc7_amd64_gcc900/src/FWCore/PyDevParameterSet/test/testPyBind11ParameterSet/testPyBind11ParameterSet] Error 1 >> Entering Package FWCore/PrescaleService >> Leaving Package FWCore/PrescaleService >> Package FWCore/PrescaleService built |
|
@davidlange6 , can you please also fix FWCore/PyDevParameterSet/test/makepset_t.cppunit.cc |
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
tests-rejected
labels
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33066/21423
|
|
Pull request #33066 was updated. @SiewYan, @smuzaffar, @andrius-k, @Dr15Jones, @mkirsano, @makortel, @ErnestaP, @ahmad3213, @GurpreetSinghChahal, @jfernan2, @kmaeshima, @alberto-sanchez, @agrohsje, @rvenditti can you please check and sign again. |
|
Yes, I understand it - but is this valid? Eg ./mybinary is distinct from mybinary when interpreted by path
… On Mar 7, 2021, at 8:03 PM, Malik Shahzad Muzaffar ***@***.***> wrote:
@smuzaffar commented on this pull request.
In FWCore/ParameterSet/src/FileInPath.cc:
>
// Does the a file exist? locateFile throws is it finds
// something goofy.
if (locateFile(pathPrefix, relativePath_)) {
// Convert relative path to canonical form, and save it.
- relativePath_ = bf::path(relativePath_).normalize().string();
+ relativePath_ = std::filesystem::weakly_canonical(std::filesystem::path(relativePath_)).string();
@davidlange6 , problem is here. For relativePath_=./Geometry/CMSCommonData/data/materials.xml (note the ./ at the start) the std::filesystem::weakly_canonical returns $PWD/Geometry/CMSCommonData/data/materials.xml instead of Geometry/CMSCommonData/data/materials.xml
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
yes that is correct as later at https://github.com/cms-sw/cmssw/pull/33066/files#diff-e2ebfebe4f2ce703776a9659be37d1701ca6934432f0007ae58472f79d4bd143R383 we concatenate |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f6804c/13326/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+1 |
|
+core |
|
+generators |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
To possibly address aarch64 build issues seen when using boost1.75 across different machines- More discussion in cms-sw/cmsdist#6698