drop type specs and move parameters inside the modifier in RecoHI

[jeongeun]

PR description:

Update the safer syntax for existing parameter :

• drop type specifications where the original parameter exists.
• move all parameter inside the clone

(The previous PR for RecoHI is PR#32031, PR#32386)

In this PR, 14 files were changed in RecoHI
RecoHI/Configuration 2 files
RecoHI/HiEgammaAlgos 1 file
RecoHI/HiTracking 5 files
RecoHI/HiMuonAlgos 6 files

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33048/21348

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33048/21348/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33048/21348/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33048/21349

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoHI/Configuration
RecoHI/HiEgammaAlgos
RecoHI/HiMuonAlgos
RecoHI/HiTracking

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[perrotta]

This one and the following modules are cloned from another module of the same name. As such, it can be confusing, and the modules could remain local to this config, which I am not sure is what is wanted (up to now this config is only used in a test script, so it is not clear whether some different usage will be ever envisaged).
My suggestion is to restore the previous RecoHI/HiTracking/python/hiRegitTracking_cff.py.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33048/21356

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #33048 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d19ca1/13240/summary.html
COMMIT: bc201b0
CMSSW: CMSSW_11_3_X_2021-03-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33048/13240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2872 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2750983
• DQMHistoTests: Total failures: 4934
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2746026
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 156 log files, 37 edm output root files, 37 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass with no relevant differences wrt baseline (random differences in 11634.911 are a recent known general issue)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1