Update GEM Offline DQM, backport to CMSSW_11_2_X

[seungjin-yang]

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33031 to CMSSW_11_2_X. This backport is needed for MWGR#3.

@jshlee @szaleski

[cmsbuild]

A new Pull Request was created by @seungjin-yang for CMSSW_11_2_X.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@barvic, @bellan, @threus, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @ptcox, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

Pull request #33032 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[seungjin-yang]

The variable name change was incomplete. phase2_GEM.toModify was taking the old variable name (etaHigh) as an named argument. The new commit fixed it and is tested with workflow 33811.0, which is TenMuExtendedE_0_200+2026D74.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83cd6a/13198/summary.html
COMMIT: 5b4511b
CMSSW: CMSSW_11_2_X_2021-03-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33032/13198/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2525881
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525850
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -604.663 KiB( 35 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -144.873 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 11634.0,... ): 80.748 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 11634.0,... ): -20.975 KiB GEM/GEMOfflineMonitor
• DQMHistoSizes: changed ( 23234.0,... ): -218.818 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 23234.0,... ): 141.314 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 23234.0,... ): -38.949 KiB GEM/GEMOfflineMonitor
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[jfernan2]

There seems to be Clang warnigns to fix:
DQMOffline/Muon/src/GEMEfficiencyAnalyzer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2021-03-02-1100/src/DQMOffline/Muon/src/GEMEfficiencyAnalyzer.cc:583:26: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2021-03-02-1100/src/DQMOffline/Muon/src/GEMEfficiencyAnalyzer.cc:585:26: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2021-03-02-1100/src/DQMOffline/Muon/src/GEMEfficiencyAnalyzer.cc:622:22: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]

[cmsbuild]

Pull request #33032 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[seungjin-yang]

@jfernan2 I removed abused move semantics as I did in PR to master #33031. By the way, I have a question about the code quality check. When I ran scram build code-checks, it threw one -Wpessimizing-move warning. However, scram build COMPILER='llvm compile' threw more same warnings. Is the latter command is more strict? If not, do I need to run both commands? Thanks In Advance.

[jfernan2]

I do not know the answer to your question, I let the experts to comment.
Triggering the tests again to see if your update works

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83cd6a/13231/summary.html
COMMIT: 1070efc
CMSSW: CMSSW_11_2_X_2021-03-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33032/13231/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2525881
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525846
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -604.655 KiB( 35 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -144.873 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 11634.0,... ): 80.748 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 11634.0,... ): -20.975 KiB GEM/GEMOfflineMonitor
• DQMHistoSizes: changed ( 23234.0,... ): -218.818 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 23234.0,... ): 141.314 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 23234.0,... ): -38.949 KiB GEM/GEMOfflineMonitor
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[jfernan2]

please test
It looks fine but triggering tests again to see if Failed Tests: RelVals-INPUT is overcome

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-83cd6a/13244/summary.html
COMMIT: 1070efc
CMSSW: CMSSW_11_2_X_2021-03-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33032/13244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2525881
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2525858
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -604.659 KiB( 35 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -144.873 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 11634.0,... ): 80.748 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 11634.0,... ): -20.975 KiB GEM/GEMOfflineMonitor
• DQMHistoSizes: changed ( 23234.0,... ): -218.818 KiB GEM/GEMEfficiency
• DQMHistoSizes: changed ( 23234.0,... ): 141.314 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 23234.0,... ): -38.949 KiB GEM/GEMOfflineMonitor
• Checked 151 log files, 37 edm output root files, 36 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[seungjin-yang]

I do not know the answer to your question, I let the experts to comment.
Triggering the tests again to see if your update works

@jfernan2 Thank you so much!

[qliphy]

+1