-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove not needed RooFit dependencies from BuildFiles #33019
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33019/21303
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: CalibMuon/DTCalibration @malbouis, @andrius-k, @yuanchao, @kmaeshima, @christopheralanwest, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @srimanob, @jfernan2, @kpedro88, @tlampen, @pohsun, @rvenditti, @santocch, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Comparison SummarySummary:
|
I suppose the DAS errors are unrelated to the PR? |
correct, das errors are not related to this PR. please ignore these errors for now and feel free to sign the PR |
+1 |
Pull request #33019 was updated. @malbouis, @yuanchao, @christopheralanwest, @kpedro88, @rekovic, @srimanob, @tlampen, @pohsun, @santocch, @cecilecaillol, @francescobrivio can you please check and sign again. |
Thanks @smuzaffar. Well, I had to rebase anyway so the tests have to be ran one more time actually. |
-1 Failed Tests: RelVals-INPUT
RelVals-INPUT
Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ddbbe/13220/summary.html Comparison SummarySummary:
|
There seems to be Static Check build errors |
+alca |
+analysis |
kind reminder @cms-sw/upgrade-l2 @cms-sw/l1-l2 |
+Upgrade |
merge |
+1 |
PR description:
Another quick BuildFile cleaning PR in the style of many before (for example #32762).
This one targets all the
roofit
androofitcore
dependencies so we can better keep track where RooFit is used.PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.