Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not needed RooFit dependencies from BuildFiles #33019

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Remove not needed RooFit dependencies from BuildFiles #33019

merged 1 commit into from
Mar 8, 2021

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #32762).

This one targets all the roofit and roofitcore dependencies so we can better keep track where RooFit is used.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33019/21303

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

CalibMuon/DTCalibration
DQM/MuonMonitor
ElectroWeakAnalysis/ZMuMu
HeavyFlavorAnalysis/Onia2MuMu
L1Trigger/DTTriggerPhase2
PhysicsTools/FWLite
PhysicsTools/TagAndProbe
PhysicsTools/Utilities

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @christopheralanwest, @ErnestaP, @ahmad3213, @cmsbuild, @rekovic, @srimanob, @jfernan2, @kpedro88, @tlampen, @pohsun, @rvenditti, @santocch, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @tocheng, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ddbbe/13147/summary.html
COMMIT: 0da3355
CMSSW: CMSSW_11_3_X_2021-02-28-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33019/13147/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 11725.0DAS Error
  • 11925.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750958
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@guitargeek
Copy link
Contributor Author

I suppose the DAS errors are unrelated to the PR?

@smuzaffar
Copy link
Contributor

correct, das errors are not related to this PR. please ignore these errors for now and feel free to sign the PR

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 1, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

Pull request #33019 was updated. @malbouis, @yuanchao, @christopheralanwest, @kpedro88, @rekovic, @srimanob, @tlampen, @pohsun, @santocch, @cecilecaillol, @francescobrivio can you please check and sign again.

@guitargeek
Copy link
Contributor Author

Thanks @smuzaffar. Well, I had to rebase anyway so the tests have to be ran one more time actually.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ddbbe/13167/summary.html
COMMIT: 51ce68f
CMSSW: CMSSW_11_3_X_2021-02-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33019/13167/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 11725.0DAS Error
  • 11925.0DAS Error

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2750952
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@christopheralanwest
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ddbbe/13220/summary.html
COMMIT: 51ce68f
CMSSW: CMSSW_11_3_X_2021-03-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33019/13220/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2750983
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2750946
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 3, 2021

There seems to be Static Check build errors
There are also some differences in L1TEMU// L1TdeStage2uGMT / data_vs_emulator_comparison but probably unrelated to this PR
https://tinyurl.com/yclrxnlc

@tlampen
Copy link
Contributor

tlampen commented Mar 3, 2021

+alca

@silviodonato
Copy link
Contributor

+analysis

@silviodonato
Copy link
Contributor

kind reminder @cms-sw/upgrade-l2 @cms-sw/l1-l2

@srimanob
Copy link
Contributor

srimanob commented Mar 8, 2021

+Upgrade

@silviodonato
Copy link
Contributor

merge
@cms-sw/l1-l2 please let us know if you have any objections

@santocch
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants