Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hlt customisations 11.2.x #32962

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Feb 22, 2021

PR description:

Extend the functionality of the hltGetConfiguration --hilton option:

  • use the DAQ source and output modules
  • do not apply the STORM-specific customisation

PR validation:

None.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #32961 to the CMSSW 11.2.x stable branch.

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 22, 2021

backport #32961

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Feb 22, 2021
@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 22, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_2_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3fad0/13013/summary.html
COMMIT: cb02452
CMSSW: CMSSW_11_2_X_2021-02-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32962/13013/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2528845
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2528819
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 25, 2021

+1

@cmsbuild cmsbuild merged commit 918317f into cms-sw:CMSSW_11_2_X Feb 25, 2021
@fwyzard fwyzard deleted the Update_HLT_customisations_11.2.x branch August 18, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants