-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customisation to make sure that upgrade WFs will cross LS in the short matrix #32957
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32957/21195
|
A new Pull Request was created by @srimanob (Phat Srimanobhas) for master. It involves the following packages: Configuration/PyReleaseValidation @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a291b/12999/summary.html Comparison SummarySummary:
|
+Upgrade |
@srimanob a few questions:
|
Regarding point 2 that @kpedro88 raises - this change would also mean that the gem-sim is not so useful as a basis for any sort of performance studies. |
hold To modify the PR, to run on a workflow only, just to make sure things run properly. |
Pull request has been put on hold by @srimanob |
kind reminder @srimanob |
@srimanob please push on "Ready for review" when the PR will be ready |
Close ... to make it in a new way. |
PR description:
This purpose of this PR is to add customisation on GEN-SIM step which will force all upgrade WFs to cross LS in the short matrix. It should not affect relvals submitted by PdmV. Crossing LS in the short matrix will help us to identify rare issues that can happen during crossing LS as we spotted lately in the past.
PR validation:
Config from the following command runs fine.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport is needed.