-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort the imports in the split configuration #32904
Sort the imports in the split configuration #32904
Conversation
When generating a split configuration, remove duplicates, and sort the import in each file by section and by module name.
backport #32754 |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_11_1_X. It involves the following packages: FWCore/ParameterSet @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01d4a3/12871/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When generating a split configuration, sort the import in each file by section and by module name.
For example, before:
after:
PR validation:
None.
If this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #32754 to 11.1.x, used to build the Phase 2 HLT menu (see #32903).