Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to leave an interactive gdb session on crash #32810

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

dan131riley
Copy link

PR description:

This PR adds an option for the stack trace handler to attach to gdb and leave an interactive session, instead of printing a backtrace and detaching. This allows for interactive investigation of bugs (particularly threading bugs) that don't manifest when run under gdb.

PR validation:

Tested (via kill -SIGBUS) that the default behavior is still the same, but with

process.InitRootHandlers = cms.Service('InitRootHandlers',
    InteractiveDebug = cms.untracked.bool(True)
)

the bus error signal leaves the terminal at an interactive (gdb) prompt attached to cmsRun.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32810/20994

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32810/20995

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

FWCore/Services

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Feb 3, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b43ca/12699/summary.html
COMMIT: 57e071c
CMSSW: CMSSW_11_3_X_2021-02-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32810/12699/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2752926
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2752897
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@makortel
Copy link
Contributor

makortel commented Feb 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Feb 4, 2021

+1

@cmsbuild cmsbuild merged commit e7e1c00 into cms-sw:master Feb 4, 2021
@dan131riley dan131riley deleted the interactive-gdb-option branch February 4, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants