Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM GT to 112X in view of MWGR #32800

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Feb 3, 2021

PR description:

Fixes #32796

following comment:

#32796 (comment)

Tested that the issue above is solved

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32800/20972

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQM/Integration

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2 jfernan2 changed the title Changed GT to 112X [L1T] Changed GT to 112X in view of MWGR Feb 3, 2021
@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

FYI @rekovic

@mmusich
Copy link
Contributor

mmusich commented Feb 3, 2021

shouldn't something similar be done also for:

GlobalTag.globaltag = "111X_dataRun3_Express_v4"

(as a fallback protection during operations)?

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

Thanks @mmusich
Certainly yes, we are waiting for the GT to be used in the next MWGR in express and prompt

@jfernan2 jfernan2 changed the base branch from master to CMSSW_11_2_X February 3, 2021 10:14
@cmsbuild cmsbuild modified the milestones: CMSSW_11_3_X, CMSSW_11_2_X Feb 3, 2021
@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

please abort

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

please test
Now in 112X

@silviodonato
Copy link
Contributor

Thank you for the fix.
We need a similar PR also in 11_3_X (the unit tests are failing both in 11_3 and 11_2)

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

OK @silviodonato however it is not clear to me if we should use the 112X GT in 113X too, indeed AlCaDB is still working on a candidate for express and prompt GTs:

https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4373.html

@silviodonato
Copy link
Contributor

urgent
for the MWGR

@cmsbuild cmsbuild added the urgent label Feb 3, 2021
@christopheralanwest
Copy link
Contributor

Thanks @mmusich
Certainly yes, we are waiting for the GT to be used in the next MWGR in express and prompt

OK @silviodonato however it is not clear to me if we should use the 112X GT in 113X too, indeed AlCaDB is still working on a candidate for express and prompt GTs:

https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4373.html

You can use the 112X_dataRun3_Express_v2 GT for the express GT and 112X_dataRun3_Prompt_v2 for the prompt GT. These are likely to be the GTs used for the upcoming MWGR. There are no new features in 113X that are not present in 112X so for now we simply use the 112X GT for both 11_2_X and 11_3_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

Pull request #32800 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

@jfernan2 jfernan2 changed the title [L1T] Changed GT to 112X in view of MWGR DQM GT to 112X in view of MWGR Feb 3, 2021
@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 3, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e52862/12684/summary.html
COMMIT: 42883f3
CMSSW: CMSSW_11_2_X_2021-02-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/32800/12684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2529619
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529578
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 151 log files, 37 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor Author

jfernan2 commented Feb 4, 2021

+1
Tested at P5 with DQM Online

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5ed8d1d into cms-sw:CMSSW_11_2_X Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in two L1 TestDQMOnlineClient unit tests
5 participants