-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch modifiers to pp_on_AA for hiEvtPlane #32541
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32541/20493
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for master. It involves the following packages: RecoHI/HiEvtPlaneAlgos @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-062aed/11791/summary.html DAS Queries failed Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
pp_on_AA is a common modifier for HI, as introduced in #31935.
RecoHI/HiEvtPlaneAlgos/python/HiEvtPlane_cfi.py was apparently left over.
The update should be technical at this point.
this update was confirmed with @mandrenguyen