-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DQM/EcalMonitorTasks] Add MEM FE Status and Integrity Error Plots #32481
Conversation
A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_11_2_X. It involves the following packages: DQM/EcalMonitorTasks @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-212224/11627/summary.html Comparison SummarySummary:
|
backport of #32443 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
During a MWGR in November 2020 (but also a few times in Run2) we noticed EcalElectronicsIds coming from the ECAL calibration stream with seemingly unphysical detector coordinates. Specifically, these were coming from the EcalIntegrityMemBlockSizeErrors collection and occurred for a number of events in runs 338624 and 338628. At least in run 338628, this was always occurring with the same unphysical coordinates:
MemBlockSizeError:
dccId: 24
towerId: 70
It turns out that towerIDs 69 and 70 correspond to the MEM boxes for most ECAL SMs. These MEM boxes also have a front-end (FE) status that was not being displayed, due to the code assuming these coordinates are unphysical.
Integrity errors for towerID 69 had been masked before not knowing that these towerIDs do have a meaning: 95eed04
In this PR we now handle the two additional tower IDs and plots the FE status and integrity errors for these MEM boxes. The plots contain two bins for each SM corresponding to tower IDs 69 and 70, respectively. The plots are indexed by ECAL DCC ID, where each DCC ID corresponds to a SM. The mapping from DCC ID to SM name appears below.
PR validation:
New plots successfully generated with online ECAL DQM workflow and uploaded to a private DQM GUI without any issues.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of the original PR here: #32443
This is done to ensure the changes are available in CMSSW_11_2_X, which would be used in the next MWGR in February 2021.