-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve method to get largest module ID in ProcessCallGraph #32409
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32409/20277
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
abd449d
to
da9a924
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32409/20278
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: HLTrigger/Timer @Martin-Grunewald, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 |
Comparison results are now available Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up to #29584 and #29553. It updates the method to get the largest module ID in
ProcessCallGraph
to be the same as was done forDependencyGraph
in #29584. See https://github.com/cms-sw/cmssw/pull/29553/files#r435294147 for a bit more details.PR validation:
Limited matrix runs.