Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding configuration files for Matchbox and standalone H7 #32337

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

theofil
Copy link
Contributor

@theofil theofil commented Nov 30, 2020

PR description:

  • adding python _cff.py and _cfg.py to run H7 in matchbox and LO standalone mode
  • matchbox cff/cfg have been made relying on Herwig7CH3TuneSettings for testing
  • no changes are expected in the output
  • no dependencies to other PRs or externals

PR validation:

passed successfully the:
https://cms-sw.github.io/PRWorkflow.html

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32337/20164

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @theofil (Konstantinos Theofilatos) for master.

It involves the following packages:

GeneratorInterface/Herwig7Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor

SiewYan commented Dec 1, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

+1
Tested at: 527dbdf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96244d/11200/summary.html
CMSSW: CMSSW_11_3_X_2020-11-30-1100
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96244d/11200/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529557
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 34 edm output root files, 35 DQM output files

@SiewYan
Copy link
Contributor

SiewYan commented Dec 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a39e6f8 into cms-sw:master Dec 1, 2020
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
colizz added a commit to colizz/cmssw that referenced this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants