optimize search algorithm for EventFilter/SiStripRawToDigi/plugins/WarningSummary.cc

[mmusich]

PR description:

It has been suggested in #32220 (comment) (where a similar strategy for collecting warning messages is used) that a more efficient search algorithm for std::map can be used (by using its native O(log(n)) implementation).

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport needed

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32280/20072

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @pieterdavid, @robervalwalsh, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11030/console Started: 2020/11/25 13:18

[cmsbuild]

+1
Tested at: 4401c26
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b101e2/11030/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b101e2/11030/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2282 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 54303
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2909190
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[slava77]

+1

for #32280 4401c26

• technical ; in line with the PR description
• jenkins tests pass and comparisons show no relevant differences (diffs in 11642.911 are due to some reproducibility issues in the DD4HEP workflows)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1