Throw an exception if esConsumes() is called outside EDModule constructors

[makortel]

PR description:

#32093 (comment) reported an assertion failure inside framework code. Closer inspection revealed that the user code was calling esConsumes() outside of the constructor (or registerLateConsumes()). It would be more helpful for users to get a clear exception message (like in ED consumes() case) instead of an assertion failure. This PR adds such an exception for esConsumes().

PR validation:

Framework unit tests run.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32270/20054

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/EDConsumerBase.h modified in PR(s): Make EventSetup get to throw if called without a token when EDModule consumed any ES product #31746, Delete unscheduled modules that are not consumed by any scheduled module #29553
  • File FWCore/Framework/src/EDConsumerBase.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@Dr15Jones please review

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11012/console Started: 2020/11/24 23:54

[cmsbuild]

+1
Tested at: 4dd952a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85e1b8/11012/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85e1b8/11012/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2332 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 55092
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2908401
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[makortel]

• Reco comparison results: 2332 differences found in the comparisons
• DQMHistoTests: Total failures: 55092

Vast majority of the differences are in DD4Hep workflows. The remaining ones are related to messages.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1