-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define magnetic field parameters for Geant4e as in Geant4 #32268
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32268/20051
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: TrackPropagation/Geant4e @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@@ -20,12 +20,12 @@ | |||
Type = cms.string('CMSIMField'), | |||
StepperParam = cms.PSet( | |||
MaximumEpsilonStep = cms.untracked.double(0.01), ## in mm | |||
DeltaOneStep = cms.double(0.001), ## in mm | |||
DeltaOneStep = cms.double(1e-4),## in mm | |||
MaximumLoopCounts = cms.untracked.double(1000.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@civanch,
when trying to fix the Geant4e refitter configuration in 11.2.x for PR #32260
I had to add the following parameters:
DeltaChordTracker = cms.double(0.001), ## in mm
DeltaOneStepTracker = cms.double(1e-4),## in mm
DeltaIntersectionTracker = cms.double(1e-6),## in mm
RmaxTracker = cms.double(8000), ## in mm
ZmaxTracker = cms.double(11000), ## in mm
EnergyThTracker = cms.double(0.2), ## in GeV
shouldn't those be added here as well?
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
For Geant4e propagator use the same parameters as established for Geant4 tracking in field at SIM step in (#32063 and #31665)
PR validation:
private