-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove FastSim dependecy in Validation/RecoParticleFlow/plugins/PFAnalysis.cc #32258
Remove FastSim dependecy in Validation/RecoParticleFlow/plugins/PFAnalysis.cc #32258
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32258/20024
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Validation/RecoParticleFlow @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -14,6 +14,7 @@ | |||
<use name="CommonTools/UtilAlgos"/> | |||
<use name="Geometry/HcalTowerAlgo"/> | |||
<use name="MagneticField/Records"/> | |||
<use name="FastSimulation/CaloGeometryTools"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem like a dependency we want? In any case it looks like Transform3DPJ.h is just copied from root - perhaps the better solution is to depend on root directly;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks David, I've implemented your suggestion
please abort |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32258/20027
|
Pull request #32258 was updated. @andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
please test |
The tests are being triggered in jenkins.
|
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes the FastSim dependency in Validation/RecoParticleFlow/plugins/PFAnalysis.cc by replacing
Transform3DPJ
withTransform3D
from root. This PR fixes the errorSee https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc820/CMSSW_11_2_X_2020-11-23-2300/depViolationLogs/Validation/RecoParticleFlow
PR validation:
I tested
ReleaseDepsChecks.pl
and the errors has disappeared after the fix .