Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GEN-SIM string in runTheMatrix for 11_2_X #32140

Merged
merged 4 commits into from
Nov 21, 2020

Conversation

chayanit
Copy link

@chayanit chayanit commented Nov 14, 2020

This is a PR to update GEN-SIM strings in runTheMatrix as requested by PPS (#31943 and #32003) and issue reported in #32125 .

The validation has not yet done since there are many missing GEN-SIM files, so I would like to see the list of missing inputs and produce them accordingly. Then I will update the description

@silviodonato, could you provide the command line to run -i all --ibeos test so I can get the full list of samples causing error report and produce them accordingly?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32140/19810

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @chayanit (Chayanit Asawatangtrakuldee) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @wajidalikhan, @kpedro88, @jordan-martins can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test
@smuzaffar added a test that checks the output of the DAS query. This should allow you to find the missing files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 14, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

the new feature is cms-sw/cms-bot#1412

@cmsbuild
Copy link
Contributor

-1

Tested at: 43ce8b3

CMSSW: CMSSW_11_2_X_2020-11-13-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10751/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
23434.999 step2

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

  • DAS Queries: The DAS query tests failed, see the summary page for details.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor

-1

Tested at: 43ce8b3

CMSSW: CMSSW_11_2_X_2020-11-13-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10751/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

* **RelVals**:

When I ran the RelVals I found an error in the following workflows:
23434.999 step2

runTheMatrix-results/23434.999_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU/step2_TTbar_14TeV+2026D49PU_PMXS1S2PR+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+PREMIX_PremixHLBeamSpot14PU+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU.log

* **DAS Queries**: The DAS query tests failed, see the summary page for details.

@chayanit you can find the error looking for "ERROR" in
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10751/dasqueries/runall-report-step123-.log

The crash of the pileup samples are visible in the Matrix tests.

@smuzaffar did you expect to see the workflows with errors https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10751/dasqueries/failed_workflows.log ?

@smuzaffar
Copy link
Contributor

@silviodonato , yes errors should go in the fail_workflow log but I was search for wrong keyword. This is now fixed cms-sw/cms-bot@f4236bf

@chayanit
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 46463d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10886/summary.html
CMSSW: CMSSW_11_2_X_2020-11-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@chayanit
Copy link
Author

+1

@silviodonato I think this PR is ready now. All GS files have been produced

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa882f/10886/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fa882f/11624.911_TTbar_13+2021_DD4hep+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-fa882f/11642.911_ZMM_13+2021_DD4hep+ZMM_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7175 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2962300
  • DQMHistoTests: Total failures: 50823
  • DQMHistoTests: Total nulls: 58
  • DQMHistoTests: Total successes: 2911397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.117 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.117 KiB SiStrip/MechanicalView
  • Checked 158 log files, 34 edm output root files, 37 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Nov 21, 2020

@cms-sw/upgrade-l2 Do you have any comments? This PR is needed for #32003

@silviodonato
Copy link
Contributor

merge
let's try this in the morning IB

@silviodonato
Copy link
Contributor

@chayanit we have some problems with the pileup samples (see #32237)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants