-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove hgcal local reco from reconstruction_trackingOnlyTask for trackingPhase2PU140 (11_1_X backport) #32104
Conversation
A new Pull Request was created by @silviodonato (Silvio Donato) for CMSSW_11_1_X. It involves the following packages: Configuration/StandardSequences @silviodonato, @cmsbuild, @franzoni, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#6340 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged. |
Backport of #31844
This backport fixes the crash in
20434.1
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_11_1/2020-11-10-2300?selectedArchs=slc7_amd64_gcc820&selectedFlavors=X&selectedStatus=failed
Tested in
20434.1
.From @slava77's PR:
This is in response to #31743 : reconstruction_trackingOnlyTask by default includes localrecoTask, which includes calolocalrecoTask, which in turn includes hgcalLocalRecoTask.
There are no actual dependencies on products made in hgcalLocalRecoTask.
This also removed castorreco from reconstruction_trackingOnlyTask, which is not needed/used either.
A recent update in #31527 introduced an explicit dependency of hgcalLocalRecoTask on tracking and broke reconstruction_trackingOnlyTask.
I propose to simply remove dependence on hgcalLocalRecoTask at this point (rather than picking individual unwanted modules).
tested on 23234.1 (phase-2 D49 trackingOnly wf)
@JanFSchulte @felicepantaleo @rovere