NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz

[mdunser]

PR description:

This PR is to pass through all muons from MiniAOD to NanoAOD above pT > 15 GeV, regardless of the ID. This is needed to make more detailed tag-and-probe efficiency studies for the w-mass measurement.

The total size difference is of the order of 0.25%. We ran tests on 50k events for ttbar and dy and the difference in size is:

ttbar: 105727232 vs. 105437681 bytes with pass-through ON versus OFF, ratio 1.00275
(41754 versus 37945 muons, 10% more)
dy: 61925228 vs. 61753275 bytes with pass-through ON versus OFF, ratio: 1.00278
(68772 versus 66746 muons, 3% more)

PR validation:

Ran 50k Mini->Nano events for DY and ttbar MC in the SMP-RunIISummer16NanoAODv8 campaign.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32103/19756

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mdunser for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-10-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10648/console Started: 2020/11/11 15:30

[mariadalfonso]

@mdunser
can you prepare at the same time the backport to 10_6

[mdunser]

the backport PR to the CMSSW_10_6_X branch is here: #32107

[cmsbuild]

+1
Tested at: bf3e074
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f571e/10648/summary.html
CMSSW: CMSSW_11_2_X_2020-11-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[mariadalfonso]

The total size difference is of the order of 0.25%. We ran tests on 50k events for ttbar and dy and the difference in size is:

In data (Single/Dimuon) different eras the size increase is in the range 1%-1.4%

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f571e/10648/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 134 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2529296
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2529259
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 148 log files, 22 edm output root files, 35 DQM output files

[mariadalfonso]

@mdunser @bendavid

not clear to us if this update goes in the right direction. And the size additions is not negligible #32103 (comment).

We expected for Wmass you will go for a private renanoAOD because

1. you need tracks to complete the tag and probe,
2. need to do the muon refitting
3. the precision of some variable like in central nanoAOD is not enough

We prefer to have a discussion at the next xPOG on nov25.
I will put on hold this PR until then

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32103/21704

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #32103 was updated. @cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please check and sign again.

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f571e/13678/summary.html
COMMIT: aa90481
CMSSW: CMSSW_11_3_X_2021-03-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32103/13678/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 179 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639935
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639912
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

• Double Muon is now +4.2% (this is considered the worst case scenario and the dataset is small); JetHT is +0.8%
• both muon/isotrack have the dxy and dz added ; so the cut can be applied a posteriori

@mdunser : can you update the title ?
NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz

@sscruz
take note and let us know if additional limitations for the T&P exist from the muon POG point of view

[sscruz]

@mariadalfonso this looks good for us, with this PR we will have most ingredients we need for tnp measurements in the Z. Something I don't see here is the isStandandAlone muon flag (was proposed by @mdunser et al in https://indico.cern.ch/event/994591/contributions/4239801/attachments/2210344/3740674/xpog_wmass.pdf), that would be useful for us. Is that expected to go in another PR?

[mdunser]

@mdunser : can you update the title ?
NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz

@mariadalfonso : done!

[mariadalfonso]

@mariadalfonso this looks good for us, with this PR we will have most ingredients we need for tnp measurements in the Z. Something I don't see here is the isStandandAlone muon flag (was proposed by @mdunser et al in https://indico.cern.ch/event/994591/contributions/4239801/attachments/2210344/3740674/xpog_wmass.pdf), that would be useful for us. Is that expected to go in another PR?

@sscruz
it went in with this PR https://github.com/cms-sw/cmssw/pull/33208/files

[mariadalfonso]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1