Change track muon dataformats scouting (11.1.x) #32078

jsalfeld · 2020-11-10T11:41:18Z

…roducers

PR description:

This is a back port of:
#31962

It includes changes to Scouting Producers and data formats. Due to the back port from 11.2.X, there are 4 small additional changes for which I checked that it compiles and the scouting event content is filled.

The differences are:

1.) removal of in DataFormats/Scouting/BuildFile.xml
2.) replacing outRho.reset(new double(*rho)); with outRho = std::make_unique(*rho); and alike for MET in HLTrigger/JetMET/plugins/HLTScoutingPFProducer.cc

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a back port of:
#31962

backport is needed for timely release of Run-3 scouting investigations

… and producers

cmsbuild · 2020-11-10T11:41:43Z

A new Pull Request was created by @jsalfeld (Jakob Salfeld-Nebgen) for CMSSW_11_1_X.

It involves the following packages:

DataFormats/Scouting
HLTrigger/Egamma
HLTrigger/JetMET
HLTrigger/Muon

@smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@abbiendi, @Fedespring, @Martin-Grunewald, @calderona, @HuguesBrun, @jhgoh, @rovere, @trocino, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from Change track muon dataformats scouting #31962

Martin-Grunewald · 2020-11-10T12:46:52Z

please test

cmsbuild · 2020-11-10T12:47:14Z

The tests are being triggered in jenkins.

CMSSW_11_1_X_2020-11-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10614/console Started: 2020/11/10 13:51

cmsbuild · 2020-11-10T14:16:37Z

+1
Tested at: e6a6951
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca3c6/10614/summary.html
CMSSW: CMSSW_11_1_X_2020-11-10-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-10T14:16:39Z

Comparison job queued.

cmsbuild · 2020-11-10T16:05:14Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca3c6/10614/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2784828
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784777
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

Fix read i/o rules for backward accessibility of scouting dataset

cmsbuild · 2020-11-10T16:44:53Z

Pull request #32078 was updated. @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @Martin-Grunewald, @fwyzard can you please check and sign again.

Martin-Grunewald · 2020-11-10T17:29:15Z

please test

cmsbuild · 2020-11-10T17:29:46Z

The tests are being triggered in jenkins.

CMSSW_11_1_X_2020-11-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10625/console Started: 2020/11/10 18:30

cmsbuild · 2020-11-24T20:22:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca3c6/11002/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2784828
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784777
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 28 edm output root files, 36 DQM output files

Martin-Grunewald · 2020-11-25T06:07:28Z

please test

cmsbuild · 2020-11-25T06:07:48Z

The tests are being triggered in jenkins.

CMSSW_11_1_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11017/console Started: 2020/11/25 08:28

cmsbuild · 2020-11-25T09:01:55Z

+1
Tested at: a857a56
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca3c6/11017/summary.html
CMSSW: CMSSW_11_1_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-25T09:01:57Z

Comparison job queued.

cmsbuild · 2020-11-25T10:53:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2ca3c6/11017/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2784828
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2784777
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 28 edm output root files, 36 DQM output files

Martin-Grunewald · 2020-11-25T11:09:19Z

+1

silviodonato · 2020-12-02T14:06:28Z

@cms-sw/core-l2 do you have any comments?

makortel · 2020-12-02T14:23:18Z

+1

(apologies for the delay)

cmsbuild · 2020-12-02T14:23:39Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-12-02T15:47:08Z

+1

jsalfeld · 2020-12-09T16:47:55Z

@silviodonato we would need this in a new release to use it in confDB. Can we request one?

silviodonato · 2020-12-09T18:21:47Z

I think I will build it tomorrow after having merged #32425

backport of PR cms-sw#31962, includes changes to Scouting dataformats…

e6a6951

… and producers

cmsbuild added this to the CMSSW_11_1_X milestone Nov 10, 2020

cmsbuild added comparison-pending core-pending hlt-pending orp-pending pending-signatures tests-pending labels Nov 10, 2020

jsalfeld mentioned this pull request Nov 10, 2020

Change track muon dataformats scouting #31962

Merged

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

mmasciov and others added 2 commits November 10, 2020 17:36

Fix read i/o rules for backward accessibility of scouting data

a628e75

Merge pull request #4 from mmasciov/fixReadIOscouting

036dcb5

Fix read i/o rules for backward accessibility of scouting dataset

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Nov 10, 2020

cmsbuild added backport-ok and removed backport labels Nov 25, 2020

cmsbuild added tests-started and removed tests-pending labels Nov 25, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 25, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 25, 2020

cmsbuild added hlt-approved and removed hlt-pending labels Nov 25, 2020

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Dec 2, 2020

cmsbuild added orp-approved and removed orp-pending labels Dec 2, 2020

cmsbuild merged commit aba9403 into cms-sw:CMSSW_11_1_X Dec 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change track muon dataformats scouting (11.1.x) #32078

Change track muon dataformats scouting (11.1.x) #32078

jsalfeld commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

Martin-Grunewald commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

Martin-Grunewald commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 24, 2020

Martin-Grunewald commented Nov 25, 2020

cmsbuild commented Nov 25, 2020 •

edited

Loading

cmsbuild commented Nov 25, 2020

cmsbuild commented Nov 25, 2020

cmsbuild commented Nov 25, 2020

Martin-Grunewald commented Nov 25, 2020

silviodonato commented Dec 2, 2020

makortel commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

silviodonato commented Dec 2, 2020

jsalfeld commented Dec 9, 2020

silviodonato commented Dec 9, 2020

Change track muon dataformats scouting (11.1.x) #32078

Change track muon dataformats scouting (11.1.x) #32078

Conversation

jsalfeld commented Nov 10, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Nov 10, 2020 • edited Loading

Martin-Grunewald commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 • edited Loading

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

Martin-Grunewald commented Nov 10, 2020

cmsbuild commented Nov 10, 2020 • edited Loading

cmsbuild commented Nov 24, 2020

Martin-Grunewald commented Nov 25, 2020

cmsbuild commented Nov 25, 2020 • edited Loading

cmsbuild commented Nov 25, 2020

cmsbuild commented Nov 25, 2020

cmsbuild commented Nov 25, 2020

Martin-Grunewald commented Nov 25, 2020

silviodonato commented Dec 2, 2020

makortel commented Dec 2, 2020

cmsbuild commented Dec 2, 2020

silviodonato commented Dec 2, 2020

jsalfeld commented Dec 9, 2020

silviodonato commented Dec 9, 2020

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 10, 2020 •

edited

Loading

cmsbuild commented Nov 25, 2020 •

edited

Loading