-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1TCaloLayer1 unpacker modified to provide 5BX TPs to ECAL #32015
L1TCaloLayer1 unpacker modified to provide 5BX TPs to ECAL #32015
Conversation
The code-checks are being triggered in jenkins. |
-code-checks ERROR: Build errors found during clang-tidy run.
|
Needs to rebase, but presumably a duplicate of this one #32013 ? |
Yes it is not completely duplicate one file is different , but I am not sure what happens, I used CMSSW_11_1_X_2020-11-02-2300
On Nov 3, 2020, at 6:51 PM, boudoul <[email protected]<mailto:[email protected]>> wrote:
Needs to rebase, but presumably a duplicate of this one #32013<#32013> ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#32015 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABII5ZBCXCNT5GXL4U52YKLSOA7JDANCNFSM4TJBJYSA>.
|
-1 to take this off our pending list |
The code-checks are being triggered in jenkins. |
A new Pull Request was created by @asavincms for CMSSW_11_1_X. It involves the following packages: EventFilter/L1TRawToDigi @cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32015/19558
|
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
looks fine now |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
L1TCaloLayer1 unpacker modified to provide 5BX TPs to ECAL
PR validation:
Checked with data files
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: