[11.1.X] use smart pointers in SiStripClassToMonitorCondData

[mmusich]

backport of #31916

PR description:

While investigating a crash reported in the SiStrip online client during the most recent MWGR, I stumbled upon this class.
Raw pointers can become smart pointers, for extra safety.

PR validation:

Run the SiStrip Online client:

cmsrel CMSSW_11_2_X_2020-10-22-2300
cd CMSSW_11_2_X_2020-10-22-2300/src/
cmsenv
git cms-addpkg DQM/Integration
# edit the sistrip_dqm_sourceclient-live_cfg.py file not to be in live mode
scramv1 b -j 8
voms-proxy-init -voms cms
mkdir upload
cmsRun DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py dataset=/ExpressCosmics/Commissioning2020-Express-v1/FEVT runNumber=337881
cmsRun DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py dataset=/ExpressCosmics/Commissioning2020-Express-v1/FEVT runNumber=337892
cmsRun DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py dataset=/ExpressCosmics/Commissioning2020-Express-v1/FEVT runNumber=337903 

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

cc:
@sroychow @arossi83

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

DQM/SiStripMonitorSummary

@andrius-k, @kmaeshima, @ErnestaP, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from use smart pointers in SiStripClassToMonitorCondData #31916

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_1_X_2020-10-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10245/console Started: 2020/10/23 15:19

[cmsbuild]

+1
Tested at: 6567200
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1110b4/10245/summary.html
CMSSW: CMSSW_11_1_X_2020-10-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1110b4/10245/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2784776
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2784725
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1