-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maximum of pileup pT hats in JME custom NanoAOD #31831
Add maximum of pileup pT hats in JME custom NanoAOD #31831
Conversation
…s option and configured to be false as default in globals_cff.py. Switched on in custom_jme_cff.py
The code-checks are being triggered in jenkins. |
FYI JMAR convenors (@camclean @alefisico) and JERC contact (@anmalara) |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19149
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
please test workflow 25202.15,10224.15,11024.15,1325.6,1325.7,1325.8,136.7952,1329.1,136.8521 |
@nurfikri89 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31831/19164
|
A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @mariadalfonso, this only stores a single float and that it is not stored by default (by setting the flag to false) so that central nano are not touched, only just the JMEnano. |
yes, indeed, we need to know the JMEnano size increase/decrease for any update. |
Understood. Will make the test. |
Hi @mariadalfonso, by running over 5K events on a UL17 TTJets sample, the size per event is 9.478 kb/event which is an increase of 0.04% from 9.474 kb/event. |
please test workflow 25202.15,10224.15,11024.15,1325.6,1325.7,1325.8,136.7952,1329.1,136.8521 |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+xpog |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
…pu_maxpthat Backport of #31831 (Add maximum of pileup pT hats in JME custom NanoAOD) to 10_6_X
PR description:
This PR adds the maximum of the pileup pT hats into the JME custom NanoAOD. This is done by modifying
NPUTablesProducer.cc
to find the maximum value in thevector<float>
returned bygetPU_pT_hats()
and then store in the PileUp table.A flag is also added and set to false in
globals_cff.py
so that this variable will not be stored in the main NanoAODs. The flag is set to true incustom_jme_cff.py
so that it will be stored in the JME custom NanoAOD format.The variable is needed by JERC analyses, which will use the JME Custom NanoAODs.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.