drop type specs in RecoVertex RecoPixelVertexing #31784
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31784/19043
|
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages: RecoPixelVertexing/PixelLowPtUtilities @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
-1 Tested at: 0ca3101 CMSSW: CMSSW_11_2_X_2020-10-13-2300 I found follow errors while testing this PR Failed tests: Build Python3
I found compilation warning when building: See details on the summary page.
I found errors: *** Error compiling 'src/RecoPixelVertexing/PixelLowPtUtilities/python/ClusterShapeExtractor_cfi.py'... |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
| @@ -20,5 +20,5 @@ | |||
|
|
|||
| from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker | |||
| phase2_tracker.toModify(clusterShapeExtractor, | |||
| pixelSimLinkSrc = cms.InputTag('simSiPixelDigis', 'Pixel'), | |||
| pixelSimLinkSrc = 'simSiPixelDigis:Pixel'), | |||
There was a problem hiding this comment.
indeed... A right parenthesis was left after the InputTag
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31784/19057
|
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Update the safer syntax for existing parameter :
Instead of modifying parameters with full type specs, which can be interpreted as an insertion of a new parameter, it is a safer way to protect from parameter name mistakes and will also help in possible parameter migrations.
(The previous PR were PR#31162,PR#31243,PR#31332, PR#31389, PR#31523, PR#31538, PR#31748)
In this PR, total 5 files changed.
RecoVertex/Configuration : 2 files
RecoPixelVertexing/PixelLowPtUtilities : 2 files
RecoPixelVertexing/PixelTriplets : 1 file
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_2_X, the basic test all passed in the CMSSW PR instructions.